<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4613/">https://reviewboard.asterisk.org/r/4613/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 20th, 2015, 1:40 p.m. CEST, <b>Matt Jordan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Over the past week, Asterisk has moved to Git. The migration was announced and discussed on the asterisk-dev list.
We are now using Gerrit for code reviews (gerrit.asterisk.org). You can find instructions for using Gerrit on the Asterisk wiki:
https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage
Information about the Git servers and other policies can be found here:
https://wiki.asterisk.org/wiki/display/AST/Git+Usage
While it's a bit of a pain to move the patch over, in the long run, this should make managing the clang fixup patches much easier.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi Matt,
Thanks for the heads up. Will make the move to Git + Gerrit. From what i read on the mailinglist posts i though you were still experimenting. I guess I missed the final move announcement :-)
BTW: This is the last series of small patches that would be required to get clang compilation finished. So we are almost there.</pre>
<br />
<p>- Diederik</p>
<br />
<p>On April 20th, 2015, 12:38 p.m. CEST, Diederik de Groot wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, Matt Jordan, Mark Michelson, and rmudgett.</div>
<div>By Diederik de Groot.</div>
<p style="color: grey;"><i>Updated April 20, 2015, 12:38 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-24917">ASTERISK-24917</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">clang compilation.
three warnings have been suppressed (in Makefile.rules), which were deemed unsuitable for asterisk:
- unused-value
- parentheses-equality
- unused-command-line-argument
changes can/could be ported back to asterisk-11 if required.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiles cleanly
test execute all
455 Test(s) Executed 454 Passed 1 Failed
FAIL test_message_queue_handler_nom /main/message/ 21200ms
=====
START /main/message/ - test_message_queue_handler_nominal
[test_message.c:int handler_wait_for_message(struct ast_test *):244]: Test timed out while waiting for handler to get message
END /main/message/ - test_message_queue_handler_nominal Time: 21241ms Result: FAIL
=====
1 Test(s) Executed 0 Passed 1 Failed
== Message handler 'testmsg' registered.
-- Executing [s@default:1] wait("Message/ast_msg_queue", "1")
-- Executing [s@default:1] answer("Message/ast_msg_queue", "")
-- Digit timeout set to 5.000
-- Response timeout set to 10.000
....
-- Executing [s@default:1] background("Message/ast_msg_queue", "demo-congrats")
[Apr 18 15:22:50] ERROR[13650][C-00000000]: channel.c:5423 int set_format(struct ast_channel *, struct ast_format_cap *, const int): Unable to set format because channel Message/ast_msg_queue supports no formats
[Apr 18 15:22:50] WARNING[13650][C-00000000]: file.c:1100 int ast_streamfile(struct ast_channel *, const char *, const char *): Unable to open demo-congrats (format (none)): Function not implemented
[Apr 18 15:22:50] WARNING[13650][C-00000000]: pbx.c:11319 int pbx_builtin_background(struct ast_channel *, const char *): ast_streamfile failed on Message/ast_msg_queue for demo-congrats
.... Repeated....</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/13/res/res_security_log.c <span style="color: grey">(434725)</span></li>
<li>/branches/13/makeopts.in <span style="color: grey">(434725)</span></li>
<li>/branches/13/main/security_events.c <span style="color: grey">(434725)</span></li>
<li>/branches/13/include/asterisk/utils.h <span style="color: grey">(434725)</span></li>
<li>/branches/13/include/asterisk/autoconfig.h.in <span style="color: grey">(434725)</span></li>
<li>/branches/13/contrib/scripts/clang-scan-build <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/13/configure.ac <span style="color: grey">(434725)</span></li>
<li>/branches/13/configure <span style="color: grey">(UNKNOWN)</span></li>
<li>/branches/13/channels/chan_skinny.c <span style="color: grey">(434725)</span></li>
<li>/branches/13/autoconf/ast_check_strsep_array_bounds.m4 <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/13/autoconf/ast_check_raii.m4 <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/13/Makefile.rules <span style="color: grey">(434725)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4613/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>