<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4594/">https://reviewboard.asterisk.org/r/4594/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 7th, 2015, 6:20 p.m. UTC, <b>Matt Jordan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't see the actual patch on the issue. Did you use post-review to load the diff?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I may have closed the window before it finished. Do you see it now?</pre>
<br />
<p>- warren</p>
<br />
<p>On April 7th, 2015, 6:25 p.m. UTC, warren smith wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By warren smith.</div>
<p style="color: grey;"><i>Updated April 7, 2015, 6:25 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/asterisk-24934">asterisk-24934</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Asterisk manager output is created using printf formatting, like:
manager_event(SOME_EVENT_FLAG, "EventName",
"KeyOne: %s\r\nKeyTwo: %s\r\n", val1, val2);
This causes problems when the values themselves contain control characters like carriage return and newline, so that applications parsing the output will interpret this as a new key, or the end of an event. An example of this is having a callerid contain "\r\n\r\n". This ends the event, and the keys for the same event are interpreted as a new message, and any keys below are missed for the real event.
I've included a patch that provides a ast_escape_c() function which takes a string, then returns a pointer to a new string that has the c characters escaped (i.e., newline into \n). I've modified the calls to the manager_event functions (manager_event, ast_manager_event, ast_manager_event_multichan) so that values that could be set by a user are escaped. The string values that as far as I know aren't user-created were left as-is, like channel names and uniqueid.
There are quite a few calls to the manager event functions and I've double checked to make sure all memory allocations are freed after creating the escaped string. I also had added an ast_replace_string function which i didn't end up using, and added an ast_escape_output function which just calls ast_escape_c. An alternative would be to replace the sequence "\r\n" with the escaped version, rather than the individual characters.
I'm testing on our asterisk 11 install and this fixes the parsing bugs we run into from messed up callerids and things like agent names containing return + newline.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In our production environment I have been running the patch for about 5 days. The parsing issues we have had in the past are now resolved.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>http://svn.asterisk.org/svn/asterisk/branches/11/channels/chan_local.c <span style="color: grey">(433419)</span></li>
<li>http://svn.asterisk.org/svn/asterisk/branches/11/channels/chan_iax2.c <span style="color: grey">(433419)</span></li>
<li>http://svn.asterisk.org/svn/asterisk/branches/11/channels/chan_agent.c <span style="color: grey">(433419)</span></li>
<li>http://svn.asterisk.org/svn/asterisk/branches/11/cel/cel_manager.c <span style="color: grey">(433419)</span></li>
<li>http://svn.asterisk.org/svn/asterisk/branches/11/cdr/cdr_manager.c <span style="color: grey">(433419)</span></li>
<li>http://svn.asterisk.org/svn/asterisk/branches/11/apps/app_voicemail.c <span style="color: grey">(433419)</span></li>
<li>http://svn.asterisk.org/svn/asterisk/branches/11/apps/app_userevent.c <span style="color: grey">(433419)</span></li>
<li>http://svn.asterisk.org/svn/asterisk/branches/11/apps/app_stack.c <span style="color: grey">(433419)</span></li>
<li>http://svn.asterisk.org/svn/asterisk/branches/11/apps/app_queue.c <span style="color: grey">(433419)</span></li>
<li>http://svn.asterisk.org/svn/asterisk/branches/11/apps/app_meetme.c <span style="color: grey">(433419)</span></li>
<li>http://svn.asterisk.org/svn/asterisk/branches/11/apps/app_dial.c <span style="color: grey">(433419)</span></li>
<li>http://svn.asterisk.org/svn/asterisk/branches/11/apps/app_confbridge.c <span style="color: grey">(433419)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4594/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>