<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4539/">https://reviewboard.asterisk.org/r/4539/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 27th, 2015, 8:26 a.m. CDT, <b>Matt Jordan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think your solution here is fine.</pre>
</blockquote>
<p>On March 27th, 2015, 10:16 a.m. CDT, <b>Diederik de Groot</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi Matt, can i commit directly to the svn repository or does someone have to do this for me.
Your 'ship it' gives the impression that i can. If so is there a particular format to which the commit message has to adhere. Should it include the reviewboard number / bug report issue etc ? If not, and someone else will be doing the actual commit it would be nice if my name would be mentioned ;-)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm actually running through some commits this morning. A number of developers with commit access will commit things that have been Shipped periodically - we usually get them within a few days after they're shipped.
Attribution is given in the commit messages:
r433678 | mjordan | 2015-03-28 07:17:45 -0500 (Sat, 28 Mar 2015) | 13 lines
clang compiler warnings: Fix -Wunused-function
This patch fixes clang compilers warnings for unused functions. Specifically:
* channels/chan_iax2: removed user_ref function
* main/dsp.c: removed goertzel_update function
Review: https://reviewboard.asterisk.org/r/4527
ASTERISK-24917
Reported by: dkdegroot
patches:
rb4527.patch submitted by dkdegroot (License 6600)
Scripts in the project that build out the release summaries attribute who wrote the patch based on the 'submitted by' tag in the commit message.</pre>
<br />
<p>- Matt</p>
<br />
<p>On March 27th, 2015, 6:41 a.m. CDT, Diederik de Groot wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Diederik de Groot.</div>
<p style="color: grey;"><i>Updated March 27, 2015, 6:41 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-24917">ASTERISK-24917</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">clang's static analyzer will throw quite a number warnings / errors during compilation, some of which can be very helpfull in finding corner-case bugs.
clang compiler warning:-Winitializer-overrides
Issue:
res_pjsip/config_transport.c:382:25: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
[PJSIP_TLSV1_METHOD] = "tlsv1",
res_pjsip/config_transport.c:380:31: note: previous initialization is here
[PJSIP_SSL_DEFAULT_METHOD] = "default",
Possible Solutions:
1. PJSIP_SSL_DEFAULT_METHOD is defined as PJSIP_TLSV1_METHOD -> remove the offending initializer in line 380
2. define PJSIP_SSL_DEFAULT_METHOD locally (overriding the default define from /usr/include/pjsip/sip_transport_tls.h) and use a different value for it.
Not sure which method would be preferred, leaving that decision to the code owner.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/13/res/res_pjsip/config_transport.c <span style="color: grey">(433444)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4539/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>