<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4503/">https://reviewboard.asterisk.org/r/4503/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 24th, 2015, 10:41 p.m. UTC, <b>rnewton</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with 4488, only a few modifications made. Emailed you a diff with the changes and external extensions.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When testing this patch with 4488 I ran through the following tests:
*patch1 - internal stuff*
internal user to internal user (audio): PASS
internal user to internal user (voicemail-unavail): PASS
internal user to internal user (voicemail-busy): PASS
internal user can check voicemail: PASS
deskphone displays MWI indication: PASS
*patch2 - outside connectivity*
registration to ITSP(DCS) comes up: PASS
internal user dials out ITSP with 7 digit number: PASS
internal user dials out ITSP with 10 digit number: PASS
internal user dials out ITSP with 10+1 digit number: PASS
internal user dials main IVR internally: PASS
restricted number patterns work successfully: PASS
inbound calls reach the main IVR: PASS
external user can reach external voicemail feature via DID: PASS
external users can dial internal users directly via DID match: PASS
*patch3 - queues with external and internal access*
sales queue reached internally: PASS
externally: PASS
sales queue rings Terry, Garnet and Franny in ring-all: PASS
customer advocate queue reached internally: PASS
externally: PASS
customer advocate Queue rings Maria, Dusty and Tommie in ring-all: PASS
*patch4 - conferences*
employee conference can be dialed by internal users: PASS
at least two parties in employee conference with audio: PASS
customer conference can be dialed into by internal user and transfer in external users: PASS
at least two parties, including an external party in customer conference with audio: PASS
*ALL PATCHES COMBINED*
All IVR options go to the correct feature/extension: PASS
CDR Master.csv does not record any intra-office calls: PASS
CDR Master.csv records calls to/from the ITSP account: PASS</pre>
<br />
<p>- rnewton</p>
<br />
<p>On March 16th, 2015, 3:37 p.m. UTC, Jonathan Rose wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Jonathan Rose.</div>
<p style="color: grey;"><i>Updated March 16, 2015, 3:37 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As described on the wiki at:
> The Sales Queue may be reached externally by dialing 256-555-1200, or internally by dialing 1200.
> The Customer Experience Queue may be reached externally by dialing 256-555-1250, or internally by dialing 1250.
> Sales Queue
> Calls to the Sales Queue should ring Terry, Garnet and Franny in ring-all fashion
> If no one answers a call to the Sales Queue after 5 minutes, the caller should be directed
> to the Operator so that the Operator can take a message and have a Sales person contact the
> caller at a later time.
> Customer Advocate Queue
> Calls to the Customer Advocate Queue should ring Maria, Dusty and Tommie in ring-all
> fashion. If no one answers a call to the Customer Advocate queue after 20 minutes, the
> caller should be directed to the Operator so that the Operator can take a message and
> have a Customer Advocate contact the caller at a later time.
NOTE: This review is accidentally against trunk, but the patch is perfectly portable, so that shouldn't be a problem.
NOTE 2: External extensions for the queues still need to be added since the outside connectivity patch hasn't been merged yet
https://reviewboard.asterisk.org/r/4488/diff/#index_header</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Had some phones register as agents in the queues as well as the operator, made sure the queue members were dialed in ring-all fashion and that the timeouts occurred and the operator was dialed as expected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/configs/basic-pbx/queues.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/configs/basic-pbx/modules.conf <span style="color: grey">(432443)</span></li>
<li>/trunk/configs/basic-pbx/extensions.conf <span style="color: grey">(432443)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4503/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>