<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/4500/">https://reviewboard.asterisk.org/r/4500/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for taking a look.  I plan to give this review a couple days after 2 ship it's, it will not be rushed.  Also this review won't be committed until r4501 (the version 13 patch) has approval.</pre>
 <br />









<p>- Corey Farrell</p>


<br />
<p>On March 15th, 2015, 6:33 a.m. EDT, Corey Farrell wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By Corey Farrell.</div>


<p style="color: grey;"><i>Updated March 15, 2015, 6:33 a.m.</i></p>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-24142">ASTERISK-24142</a>, 

 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-24683">ASTERISK-24683</a>, 

 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-24805">ASTERISK-24805</a>, 

 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-24881">ASTERISK-24881</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We've had many issues related to "core stop now" or "core restart now" causing segmentation faults.  The solution to this is to change almost everything to use ast_register_cleanup.

Exceptions:
CDR: Flush records.
res_musiconhold: Kill external applications.
AstDB: Close the DB.
canary_exit: Kill canary process.

Although some changes from ast_register_atexit to ast_register_cleanup are not strictly necessary, the point is for nothing to use ast_register_atexit except where required.  For this reason the change is across the board.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled, started and ran 'core stop now'.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/branches/11/main/xmldoc.c <span style="color: grey">(432991)</span></li>

 <li>/branches/11/main/utils.c <span style="color: grey">(432991)</span></li>

 <li>/branches/11/main/udptl.c <span style="color: grey">(432991)</span></li>

 <li>/branches/11/main/translate.c <span style="color: grey">(432991)</span></li>

 <li>/branches/11/main/timing.c <span style="color: grey">(432991)</span></li>

 <li>/branches/11/main/threadstorage.c <span style="color: grey">(432991)</span></li>

 <li>/branches/11/main/test.c <span style="color: grey">(432991)</span></li>

 <li>/branches/11/main/taskprocessor.c <span style="color: grey">(432991)</span></li>

 <li>/branches/11/main/stun.c <span style="color: grey">(432991)</span></li>

 <li>/branches/11/main/pbx.c <span style="color: grey">(432991)</span></li>

 <li>/branches/11/main/named_acl.c <span style="color: grey">(432991)</span></li>

 <li>/branches/11/main/message.c <span style="color: grey">(432991)</span></li>

 <li>/branches/11/main/manager.c <span style="color: grey">(432991)</span></li>

 <li>/branches/11/main/indications.c <span style="color: grey">(432991)</span></li>

 <li>/branches/11/main/image.c <span style="color: grey">(432991)</span></li>

 <li>/branches/11/main/http.c <span style="color: grey">(432991)</span></li>

 <li>/branches/11/main/format.c <span style="color: grey">(432991)</span></li>

 <li>/branches/11/main/file.c <span style="color: grey">(432991)</span></li>

 <li>/branches/11/main/features.c <span style="color: grey">(432991)</span></li>

 <li>/branches/11/main/event.c <span style="color: grey">(432991)</span></li>

 <li>/branches/11/main/dnsmgr.c <span style="color: grey">(432991)</span></li>

 <li>/branches/11/main/data.c <span style="color: grey">(432991)</span></li>

 <li>/branches/11/main/config.c <span style="color: grey">(432991)</span></li>

 <li>/branches/11/main/cli.c <span style="color: grey">(432991)</span></li>

 <li>/branches/11/main/channel.c <span style="color: grey">(432991)</span></li>

 <li>/branches/11/main/cel.c <span style="color: grey">(432991)</span></li>

 <li>/branches/11/main/ccss.c <span style="color: grey">(432991)</span></li>

 <li>/branches/11/main/astobj2.c <span style="color: grey">(432991)</span></li>

 <li>/branches/11/main/astmm.c <span style="color: grey">(432991)</span></li>

 <li>/branches/11/main/astfd.c <span style="color: grey">(432991)</span></li>

 <li>/branches/11/main/asterisk.c <span style="color: grey">(432991)</span></li>

 <li>/branches/11/main/aoc.c <span style="color: grey">(432991)</span></li>

 <li>/branches/11/include/asterisk.h <span style="color: grey">(432991)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/4500/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>