<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4474/">https://reviewboard.asterisk.org/r/4474/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 16th, 2015, 2:55 p.m. UTC, <b>Mark Michelson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/4474/diff/3/?file=72477#file72477line225" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/include/asterisk/dns_core.h</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">225</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="k">struct</span> <span class="n">ast_dns_query</span> <span class="o">*</span><span class="nf">ast_dns_resolve_async</span><span class="p">(</span><span class="k">const</span> <span class="kt">char</span> <span class="o">*</span><span class="n">name</span><span class="p">,</span> <span class="kt">int</span> <span class="n">rr_type</span><span class="p">,</span> <span class="kt">int</span> <span class="n">rr_class</span><span class="p">,</span> <span class="n">ast_dns_resolve_callback</span> <span class="n">callback</span><span class="p">,</span> <span class="kt">void</span> <span class="o">*</span><span class="n">data</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">First off, apologies for bringing this up now rather than earlier, but I did not think of this until over this past weekend.
The main reason that ast_dns_resolve_async() returns an ast_dns_query is so that the query can be canceled by calling ast_dns_resolve_cancel(). The problem is that there is nothing that prevents the caller of ast_dns_resolve_async() from doing unwanted operations such as adding DNS results/records, or attempting to read results from the query while an async thread is currently writing them.
What I propose here is returning something other than an ast_dns_query from this function. The structure returned from ast_dns_resolve_async() could be passed to ast_dns_resolve_cancel(), and that's it. This would be similar to how ast_dns_resolve_recurring() works.</pre>
</blockquote>
<p>On March 16th, 2015, 3:21 p.m. UTC, <b>Joshua Colp</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not sure how that would stop the reading of results though. We'd need to add a lock in, which is something I was trying to avoid for the core. How hard do we want to enforce things?</pre>
</blockquote>
<p>On March 16th, 2015, 3:35 p.m. UTC, <b>Mark Michelson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The only way that it would not prevent reading of results is if you included dns_internal.h in your source file. If you don't include dns_internal.h in your source, then you would essentially have an opaque handle that was returned by ast_dns_resolve_async() and could be passed to ast_dns_resolve_cancel().</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oh, I see, yeah.</pre>
<br />
<p>- Joshua</p>
<br />
<p>On March 16th, 2015, 3:26 p.m. UTC, Joshua Colp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Joshua Colp.</div>
<p style="color: grey;"><i>Updated March 16, 2015, 3:26 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-24834">ASTERISK-24834</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This change implements the basic API as described on the DNS API wiki page. Minimal changes have been made as required based on real usage and getting a feel for it. As it is the core functionality is present. Resolvers can register, queries can be made (async / sync).
As the API was basically copy/pasted from the wiki page there still remain stubs to be filled in for higher level functionality (such as parsing and query sets).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran DNS unit tests as done by Mark, they are happy.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/main/dns_tlsa.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/main/dns_srv.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/main/dns_recurring.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/main/dns_query_set.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/main/dns_naptr.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/main/dns_core.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/include/asterisk/dns_tlsa.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/include/asterisk/dns_srv.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/include/asterisk/dns_resolver.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/include/asterisk/dns_recurring.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/include/asterisk/dns_query_set.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/include/asterisk/dns_naptr.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/include/asterisk/dns_internal.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/include/asterisk/dns_core.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4474/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>