<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4489/">https://reviewboard.asterisk.org/r/4489/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Kevin Harwell.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-24840">ASTERISK-24840</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Make sure that no matter what order the endpoint identifier modules were loaded, priority is given based on the ones specified in the new global 'endpoint_identifier_order' option.
The original patch for this issue had to be reverted due to some problems it created (original review: https://reviewboard.asterisk.org/r/4455/).
However, those problems have now been alleviated with the current patch on this review. Instead of having the associated endpoint identifier name directly contained on the identifier object (part of the externally exposed struct definition) the name is now passed in as part of the register function. The old register function has been left for backwards compatibility or for any modules that don't need to register with a name.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran the testsuite test and it still passed. Modified the test by changing the order of the identifiers and it failed (as it should have).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>branches/13/res/res_pjsip_endpoint_identifier_user.c <span style="color: grey">(432869)</span></li>
<li>branches/13/res/res_pjsip_endpoint_identifier_ip.c <span style="color: grey">(432869)</span></li>
<li>branches/13/res/res_pjsip_endpoint_identifier_anonymous.c <span style="color: grey">(432869)</span></li>
<li>branches/13/res/res_pjsip/config_global.c <span style="color: grey">(432869)</span></li>
<li>branches/13/res/res_pjsip.c <span style="color: grey">(432869)</span></li>
<li>branches/13/include/asterisk/res_pjsip.h <span style="color: grey">(432869)</span></li>
<li>branches/13/contrib/ast-db-manage/config/versions/45e3f47c6c44_add_pjsip_endpoint_identifier_order.py <span style="color: grey">(432869)</span></li>
<li>branches/13/configs/samples/pjsip.conf.sample <span style="color: grey">(432869)</span></li>
<li>branches/13/CHANGES <span style="color: grey">(432869)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4489/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>