<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4466/">https://reviewboard.asterisk.org/r/4466/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Corey Farrell.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-24833">ASTERISK-24833</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The logger currently uses an AO2 to store a callid (int). This patch changes callid's to 'unsigned int'. AO2 is not needed for callid's.
This also fixes a theoretical infinate loop if a callid is subjected to an extra unreference but left in threadstorage. If ast_log tries getting an already released callid from threadstorage, ao2_ref will log an error. This would cause ast_log to try grabbing a reference to the callid again (same thread). The probability of this is very low and requires other code to be broken, but it's not impossible.
Change in behaviour: currently the first callid == 0. This patch changes the first callid to 1 since 0 now represents the lack of callid.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran a couple tests against chan_sip and chan_iax2, visually inspected log files.
My dev system doesn't build chan_dahdi (ever), so Matt Jordan verified it still compiles.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/res/ari/resource_bridges.c <span style="color: grey">(432661)</span></li>
<li>/trunk/main/pbx.c <span style="color: grey">(432661)</span></li>
<li>/trunk/main/logger.c <span style="color: grey">(432661)</span></li>
<li>/trunk/main/features.c <span style="color: grey">(432661)</span></li>
<li>/trunk/main/dial.c <span style="color: grey">(432661)</span></li>
<li>/trunk/main/core_unreal.c <span style="color: grey">(432661)</span></li>
<li>/trunk/main/core_local.c <span style="color: grey">(432661)</span></li>
<li>/trunk/main/cli.c <span style="color: grey">(432661)</span></li>
<li>/trunk/main/channel_internal_api.c <span style="color: grey">(432661)</span></li>
<li>/trunk/main/channel.c <span style="color: grey">(432661)</span></li>
<li>/trunk/main/bridge_channel.c <span style="color: grey">(432661)</span></li>
<li>/trunk/main/bridge_basic.c <span style="color: grey">(432661)</span></li>
<li>/trunk/main/bridge.c <span style="color: grey">(432661)</span></li>
<li>/trunk/main/autoservice.c <span style="color: grey">(432661)</span></li>
<li>/trunk/include/asterisk/logger.h <span style="color: grey">(432661)</span></li>
<li>/trunk/include/asterisk/core_unreal.h <span style="color: grey">(432661)</span></li>
<li>/trunk/include/asterisk/channel.h <span style="color: grey">(432661)</span></li>
<li>/trunk/include/asterisk/bridge_channel.h <span style="color: grey">(432661)</span></li>
<li>/trunk/include/asterisk/bridge.h <span style="color: grey">(432661)</span></li>
<li>/trunk/channels/sip/include/sip.h <span style="color: grey">(432661)</span></li>
<li>/trunk/channels/sip/include/dialog.h <span style="color: grey">(432661)</span></li>
<li>/trunk/channels/sip/dialplan_functions.c <span style="color: grey">(432661)</span></li>
<li>/trunk/channels/sig_ss7.c <span style="color: grey">(432661)</span></li>
<li>/trunk/channels/sig_pri.c <span style="color: grey">(432661)</span></li>
<li>/trunk/channels/sig_analog.c <span style="color: grey">(432661)</span></li>
<li>/trunk/channels/chan_sip.c <span style="color: grey">(432661)</span></li>
<li>/trunk/channels/chan_motif.c <span style="color: grey">(432661)</span></li>
<li>/trunk/channels/chan_iax2.c <span style="color: grey">(432661)</span></li>
<li>/trunk/channels/chan_dahdi.c <span style="color: grey">(432661)</span></li>
<li>/trunk/channels/chan_bridge_media.c <span style="color: grey">(432661)</span></li>
<li>/trunk/apps/confbridge/conf_chan_announce.c <span style="color: grey">(432661)</span></li>
<li>/trunk/apps/app_mixmonitor.c <span style="color: grey">(432661)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4466/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>