<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4455/">https://reviewboard.asterisk.org/r/4455/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think a cli command that lists the currently registered identifiers might be needed. Otherwise how would you know, especially if the name of the module didn't start with res_pjsip_endpoint_identifier_*, or if you're the admin but not the compiler/installer and don't know what modules are available.
> pjsip list identifiers
<Name.............> <Module................................>
anonymous res_pjsip_endpoint_identifier_anonymous
ip res_pjsip_endpoint_identifier_ip
username res_pjsip_endpoint_identifier_user
</pre>
<br />
<p>- George Joseph</p>
<br />
<p>On March 2nd, 2015, 1:04 p.m. MST, Kevin Harwell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Kevin Harwell.</div>
<p style="color: grey;"><i>Updated March 2, 2015, 1:04 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-24840">ASTERISK-24840</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's possible to have a scenario that will create a conflict between endpoint identifiers. For instance an incoming call could be identified by two different endpoint identifiers and the one chosen depended upon which identifier module loaded first. This of course causes problems when, for example, the incoming call is expected to be identified by username, but instead is identified by ip. This patch adds a new 'global' option to res_pjsip called 'identify_by_priority'. It is a comma separated list of endpoint identifier names that specifies the order by which identifiers are processed and checked.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added a testsuite test: https://reviewboard.asterisk.org/r/4456/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>branches/13/res/res_pjsip_endpoint_identifier_user.c <span style="color: grey">(432422)</span></li>
<li>branches/13/res/res_pjsip_endpoint_identifier_ip.c <span style="color: grey">(432422)</span></li>
<li>branches/13/res/res_pjsip_endpoint_identifier_anonymous.c <span style="color: grey">(432422)</span></li>
<li>branches/13/res/res_pjsip/config_global.c <span style="color: grey">(432422)</span></li>
<li>branches/13/res/res_pjsip.c <span style="color: grey">(432422)</span></li>
<li>branches/13/include/asterisk/res_pjsip.h <span style="color: grey">(432422)</span></li>
<li>branches/13/contrib/ast-db-manage/config/versions/45e3f47c6c44_add_pjsip_identify_by_priority.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>branches/13/configs/samples/pjsip.conf.sample <span style="color: grey">(432422)</span></li>
<li>branches/13/CHANGES <span style="color: grey">(432422)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4455/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>