<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4442/">https://reviewboard.asterisk.org/r/4442/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 24th, 2015, 2:29 a.m. CST, <b>wdoekes</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't see the *_no_direction.xml files.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry about that. The files are included in the update to this review. :)</pre>
<br />
<p>- Ashley</p>
<br />
<p>On February 24th, 2015, 12:47 p.m. CST, Ashley Sanders wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Ashley Sanders.</div>
<p style="color: grey;"><i>Updated Feb. 24, 2015, 12:47 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-24824">ASTERISK-24824</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This test is to ensure that Asterisk correctly applies the direction of the media stream when a=<sendonly|recvonly|inactive|sendrecv> is missing from the offer's SDP. The expected behavior is for Asterisk to apply "sendrecv" as the direction of the media stream when no direction attribute is present in an offer's SDP. According to RFC 4566 (Section 6. SDP Attributes): "If none of the attributes "sendonly", "recvonly", "inactive", and "sendrecv" is present, "sendrecv" SHOULD be assumed as the default for sessions that are not of the conference type "broadcast" or "H332" [...]"
The test scenario:
1. From Phone A, send an offer to Phone B to establish a call
2. From Phone B, send an offer to Phone A to put the call on hold.
3. Observe that the MOH start event occurs.
4. From Phone B, send an offer to Phone A to 'un-hold' the call (ensure that the direction attribute from the offer's SDP is omitted)
5. Observe that the MOH stop event occurs.
Presently, this test fails for certain versions of Asterisk. From what I can tell, it is present from (at least) 1.8.21 up to the 11 branch.
***Note*** This is the test. It is only the test. The update to the Asterisk source is coming soon to a review board near you (well, this review board).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>./asterisk/trunk/tests/channels/SIP/sip_hold/sipp/phone_B_no_direction.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/SIP/sip_hold/sipp/phone_B_media_restrict.xml <span style="color: grey">(6458)</span></li>
<li>./asterisk/trunk/tests/channels/SIP/sip_hold/sipp/phone_B_IP_restrict.xml <span style="color: grey">(6458)</span></li>
<li>./asterisk/trunk/tests/channels/SIP/sip_hold/sipp/phone_B_IP_media_restrict.xml <span style="color: grey">(6458)</span></li>
<li>./asterisk/trunk/tests/channels/SIP/sip_hold/sipp/phone_A_no_direction.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/SIP/sip_hold/run-test <span style="color: grey">(6458)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4442/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>