<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4400/">https://reviewboard.asterisk.org/r/4400/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Ben Merrills.</div>
<p style="color: grey;"><i>Updated Feb. 8, 2015, 9:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Committed in revision 431622</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-24745">ASTERISK-24745</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This change adds the new Hangup reason to ARI Channels Hangup, "no_answer".
Currently the only supported hangup reasons are : normal, busy and congestion.
I've amended 'res/ari/resource_channels.c' to include the new hangup reason, "no_answer" which maps to AST_CAUSE_NOANSWER alias.
I've amended 'rest-api/api-docs/channels.json' to include the new value "no_answer" as part of the swagger definition of Channels/Hangup(Delete).
*Note* I created this against trunk, was unsure what to put in branch field. This could be applied to both 12 and 13 however.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. The code has been compiled.
2. The compiled version of asterisk was run and a test ari application loaded
3. The Swagger UI exposed the new hangup reason "no_answer" under the accepted values for 'reason' when pointed at the running instance of asterisk
4. A channel was created and passed to the ari application using cmd Stasis
5. The channel was then hangup via ari with a hangup cause of "no_answer"
6. SIP debug was used to confirm the correct cause was being returned by asterisk
----
SIP/2.0 480 Temporarily unavailable
Via: SIP/2.0/UDP 192.168.3.14:5063;branch=z9hG4bK-a17e20bc;received=192.168.3.14
From: "test" <sip:test@192.168.3.201>;tag=66754982239395f0o3
To: <sip:888@192.168.3.201>;tag=as258c3d5c
Call-ID: 36c8966a-1bfa6e28@192.168.3.14
CSeq: 102 INVITE
Server: Asterisk PBX SVN-trunk-r431522M
Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, REFER, SUBSCRIBE, NOTIFY, INFO, PUBLISH, MESSAGE
Supported: replaces, timer
Content-Length: 0
----
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/rest-api/api-docs/channels.json <span style="color: grey">(431537)</span></li>
<li>/trunk/res/ari/resource_channels.c <span style="color: grey">(431537)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4400/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>