<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4344/">https://reviewboard.asterisk.org/r/4344/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Matt Jordan</p>
<br />
<p>On January 15th, 2015, 9:45 a.m. CST, Mark Michelson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Mark Michelson.</div>
<p style="color: grey;"><i>Updated Jan. 15, 2015, 9:45 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-24575">ASTERISK-24575</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I cannot publish on reviews that I did not open, so instead of updating /r/4230 with a new diff, I have created this new version of the review.
The PJProject patch has already been merged in revision 4973 of PJProject (http://trac.pjsip.org/repos/changeset/4973).
The patch presented here is pretty much exactly the same as the one that cloos made on /r/4230, with the following differences:
* There is an entry in CHANGES
* Since the PJProject change that went in resulted in a new function being added, a configure script change was made to be sure the new function exists. If it does not, then a warning is written to the console if a ca_path is specified in your pjsip.conf file.
* Documentation states that PJProject 2.4 is required to use the new ca_list_path option. This is based on my educated guess that the next version of PJProject will be 2.4 and not some other number. Is there a better way to express an unreleased version of PJProject?
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ensured that the configure check worked as expected. Ensured that the configured ca_list_path is passed down to pjlib as expected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/13/res/res_pjsip/config_transport.c <span style="color: grey">(430625)</span></li>
<li>/branches/13/res/res_pjsip.c <span style="color: grey">(430625)</span></li>
<li>/branches/13/include/asterisk/res_pjsip.h <span style="color: grey">(430625)</span></li>
<li>/branches/13/include/asterisk/autoconfig.h.in <span style="color: grey">(430625)</span></li>
<li>/branches/13/configure.ac <span style="color: grey">(430625)</span></li>
<li>/branches/13/configure <span style="color: grey">(UNKNOWN)</span></li>
<li>/branches/13/configs/samples/pjsip.conf.sample <span style="color: grey">(430625)</span></li>
<li>/branches/13/CHANGES <span style="color: grey">(430625)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4344/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>