<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4328/">https://reviewboard.asterisk.org/r/4328/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 13th, 2015, 3:48 p.m. UTC, <b>jbigelow</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Under 'URI Parsing' it states: "For the purposes of transport selection the transport parameter is examined." I suggest clarifing that the transport parameter being spoke of is the 'transport' parameter for endpoint types in pjsip.conf.
* Under 'DNS SRV Resolution (If host portion is not an IP address)' it states: "This means that the original URI *must* include..." I believe 'must' should be bold without the surrounding '*'.
* Under 'Best Configuration Strategies':
* 'IPv4 Only (Single Interface)' it states "Configure a wildcard transport." Does this mean not specifying the 'transport' parameter on endpoints? I suggest to clarify this and to include an endpoint in the configuration showing that the 'transport' parameter is not specified (assuming thats what this example is about).
* 'IPv4 Only (Multiple Interfaces)': it states "This allows each transport to be specified on endpoints...". Some clarification on whether this means specifying a single transport using the 'transport' parameter or specifying multiple transports using multiple 'transport' parameters for a single endpoint? I also suggest to include configuration of endpoints showing the 'transport' parameter being used for the example.
* I suggest to either add additional examples with TLS transports. One showing the recommended way to configure endpoints where some use UDP and others use TLS.</pre>
</blockquote>
<p>On January 13th, 2015, 3:52 p.m. UTC, <b>Joshua Colp</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That's not the transport being spoken of. It literally means a SIP URI such as sip:1000@127.0.0.1;transport=tcp</pre>
</blockquote>
<p>On January 13th, 2015, 4:33 p.m. UTC, <b>Joshua Colp</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've tweaked things some, added some endpoints, and referenced the applicable section that will be used depending on their configuration.</pre>
</blockquote>
<p>On January 14th, 2015, 3:03 p.m. UTC, <b>jbigelow</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Under 'Best Configuration Strategies':
* 'IPv4 Only (Single Interface)' it states "Since there is only one transport configured this will always be used. For requests to this endpoint the logic in section 3a will be used." which needs updated due to the last couple changes.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tweaked to be more specific.</pre>
<br />
<p>- Joshua</p>
<br />
<p>On January 12th, 2015, 1:33 p.m. UTC, Joshua Colp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Joshua Colp.</div>
<p style="color: grey;"><i>Updated Jan. 12, 2015, 1:33 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The transport selection process of PJSIP (and by extension some of our own logic) can be a dark dark thing. To help illuminate what happens I have created a wiki page[1] which goes through (based on the message type) the process by which a transport is chosen and how it can potentially change.
Stuff to look at:
1. Is this detailed enough?
2. Can you follow it? If not, how could it be made clearer?
3. Are there additional common issues that should be covered?
[1] https://wiki.asterisk.org/wiki/display/~jcolp/Transport+Selection</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I opened the wiki page. It opened.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4328/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>