<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4284/">https://reviewboard.asterisk.org/r/4284/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nice naming of things.</pre>
<br />
<p>- Joshua Colp</p>
<br />
<p>On December 19th, 2014, 6:18 p.m. UTC, Mark Michelson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Mark Michelson.</div>
<p style="color: grey;"><i>Updated Dec. 19, 2014, 6:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-24412">ASTERISK-24412</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Because of label support being added to ARI continuation/origination, I decided to make sure the new feature was well-tested in order to get the feature into Asterisk 13.
The continuation test as it exists only attempts to ensure that continuing to the next priority in the dialplan works correctly. The continuation test has been overhauled to instead test 24 combinations of specifying varying contexts, extensions, priorities, and labels to ensure that all combinations direct the channel to the expected location.
There were no existing tests for originating a channel to a dialplan location, so I have added one. This test performs 12 originations that test various combinations of context, extension, priority, and label. This has half as many test cases as continuation because origination mandates that an extension must be specified. So that eliminates the other 12 test cases that continuation has where we do not specify an extension.
There is one potentially controversial change made to lib/python/ari.py. I found it kind of annoying that I could not originate a channel and specify variables on it from my test-config.yaml. So I modified the post and put functions to be able to do this. If the 'json' key exists in the keyword parameters, it is popped out of the parameters and passed to the requests library function as its json parameter. This way, I could do the entire origination test in test-config.yaml.
The big thing I'm looking for on this test is to make sure that the assumptions about where to continue/originate when certain pieces of information are omitted makes sense.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The tests send channels to all the expected locations. If I modify locations in tests, I have verified that the channels go to the modified locations instead.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/rest_api/continue/test-config.yaml <span style="color: grey">(6075)</span></li>
<li>/asterisk/trunk/tests/rest_api/continue/rest_continue.py <span style="color: grey">(6075)</span></li>
<li>/asterisk/trunk/tests/rest_api/continue/configs/ast1/extensions.conf <span style="color: grey">(6075)</span></li>
<li>/asterisk/trunk/tests/rest_api/channels/tests.yaml <span style="color: grey">(6076)</span></li>
<li>/asterisk/trunk/tests/rest_api/channels/originate_to_dialplan/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/rest_api/channels/originate_to_dialplan/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/ari.py <span style="color: grey">(6075)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4284/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>