<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4296/">https://reviewboard.asterisk.org/r/4296/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/4296/diff/1/?file=70013#file70013line604" style="color: black; font-weight: bold; text-decoration: underline;">/branches/13/res/res_pjsip_refer.c</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static void refer_blind_callback(struct ast_channel *chan, struct transfer_channel_data *user_data_wrapper,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">603</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="n">pjsip_hdr_print_on</span><span class="p">(</span><span class="n">refer</span><span class="o">-></span><span class="n">replaces</span><span class="p">,</span> <span class="n">replaces</span><span class="p">,</span> <span class="k">sizeof</span><span class="p">(</span><span class="n">replaces</span><span class="p">))<span class="hl">;</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">604</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="hl"><span class="tb"> </span><span class="tb"> </span></span><span class="k"><span class="hl">if</span></span><span class="hl"> </span><span class="p"><span class="hl">(</span></span><span class="n">pjsip_hdr_print_on</span><span class="p">(</span><span class="n">refer</span><span class="o">-></span><span class="n">replaces</span><span class="p">,</span> <span class="n">replaces</span><span class="p">,</span> <span class="k">sizeof</span><span class="p">(</span><span class="n">replaces</span><span class="p">))</span><span class="hl"> </span><span class="o"><span class="hl">!=</span></span><span class="hl"> </span><span class="o"><span class="hl">-</span></span><span class="mi"><span class="hl">1</span></span><span class="p"><span class="hl">)</span></span><span class="hl"> </span><span class="p"><span class="hl">{</span></span></pre></td>
</tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">604</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="n">pbx_builtin_setvar_helper</span><span class="p">(</span><span class="n">chan</span><span class="p">,</span> <span class="s">"__SIPREPLACESHDR"</span><span class="p">,</span> <span class="n">S_OR</span><span class="p">(</span><span class="n">replaces</span><span class="p">,</span> <span class="nb">NULL</span><span class="p">));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">605</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="n">replaces_val</span> <span class="o">=</span> <span class="n">replaces</span> <span class="o">+</span> <span class="k">sizeof</span><span class="p">(</span><span class="s">"Replaces:"</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't think pjsip places a null terminator on the filled in string. May need to get the result of the function and add it: replaces[res] = '\0'</pre>
</div>
<br />
<p>- Kevin Harwell</p>
<br />
<p>On December 23rd, 2014, 4:46 p.m. CST, Mark Michelson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Mark Michelson.</div>
<p style="color: grey;"><i>Updated Dec. 23, 2014, 4:46 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-24376">ASTERISK-24376</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ASTERISK-24376 was created because at SIPit there was confusion about how to get remote attended transfers to work properly when using chan_pjsip.
To address this, I investigated the code and discerned what the intended way to perform a remote attended transfer is. I documented my findings on the following wiki page: https://wiki.asterisk.org/wiki/pages/viewpage.action?pageId=31096903
Please review the wiki page to ensure it makes sense.
While setting up a remote attended transfer, I came across a couple of minor issues. The following bug fixes are attached on this review:
* When sending an INVITE with a Replaces header, the Replaces header was malformed. It had the word "Replaces" twice.
* There was an error message that made it sound like external_replaces was a context being searched for, when it's actually an extension. I changed the log message to be more clear.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have manually tested this, and I've found that remote attended transfers work as expected with the patch applied. I'm in the process of writing a testsuite test but am fighting with PJSUA at the moment. Since I am going on vacation for a couple of weeks, I felt I should go ahead and get this review posted now. You'll see a testsuite review go up sometime at the start of 2015. Happy Holidays!</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/13/res/res_pjsip_refer.c <span style="color: grey">(429698)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4296/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>