<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4270/">https://reviewboard.asterisk.org/r/4270/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Matt Jordan.</div>
<p style="color: grey;"><i>Updated Dec. 17, 2014, 6:36 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Addressed findings.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Prior to this patch, a test could only provide a single required minimum version of Asterisk. This doesn't bode well for tests that have been added due to bugs, which typically require a minimum version for each active branch of Asterisk. Not allowing multiple minimum versions to be specified would result in the test being erroneously executed for higher branches of Asterisk, resulting in false test failures.
Take, for example, tests/channels/SIP/no_ack_dialog_cleanup. This test was added for ASTERISK-20784, the fix of which was released in 1.8.32.0, 11.14.0, 12.7.0, and 13.0.0-beta3. Because only a single version could be specified, however, the best the test writer could do was provide the 1.8 version:
properties:
minversion: '1.8.32.0'
This would prevent 1.8.31.0 from running against the test, but 11.13.0 would execute the test, as it is greater than the supplied minversion of 1.8.32.0.
However, if we specify a list of minversions:
minversion: ['1.8.32.0', '11.14.0', '12.7.0', '13.0.0-beta3']
Then we can determine that 11.13.0 is less than 11.14.0, and prevent the test from running.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested that:
1.8.31.0, 11.6-cert (branch), 11.6-cert8, and 13.0.0-beta2 won't run the two tests modified in this patch
1.8.32.0, 11.14.0, 13 (branch) will run the two tests modified in this patch
Versions outputted from the '-l' option appear to be correct for all versions listed above</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/channels/SIP/no_ack_dialog_cleanup/test-config.yaml <span style="color: grey">(6106)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/invite_retransmit/test-config.yaml <span style="color: grey">(6106)</span></li>
<li>/asterisk/trunk/runtests.py <span style="color: grey">(6105)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/test_config.py <span style="color: grey">(6105)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4270/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>