<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4263/">https://reviewboard.asterisk.org/r/4263/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and kmoore.</div>
<div>By wdoekes.</div>
<p style="color: grey;"><i>Updated Dec. 16, 2014, 10:44 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added fixes not found in 1.8 but only in 11.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-24619">ASTERISK-24619</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">r413586 introduced changes (amongst others) like:
- out += sprintf(out, "%%%02X", (unsigned char) *ptr);
+ out += sprintf(out, "%%%02X", (unsigned) *ptr);
But for high-ascii, that results in lots of FF's, for example:
printf("%02X\n", (unsigned)("å"[0])); /* "FFFFFFC3" */
This changeset attempt to rectify those by using the 'hh' modifier:
$ man sprintf | grep hh -A4 | head -n4
hh A following integer conversion corresponds to a
signed char or unsigned char argument, or a follow‐
ing n conversion corresponds to a pointer to a
signed char argument.
I also replaced occurrences of 2.2x with 02x. They appear to be equal.
This issue was reported by Stefan27 on IRC.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It compiles with gcc 4.8. Did not test with gcc 4.10 which was
the cause for the r413586 fixes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/11/utils/smsq.c <span style="color: grey">(429611)</span></li>
<li>/branches/11/utils/astman.c <span style="color: grey">(429611)</span></li>
<li>/branches/11/res/res_rtp_asterisk.c <span style="color: grey">(429611)</span></li>
<li>/branches/11/res/res_pktccops.c <span style="color: grey">(429611)</span></li>
<li>/branches/11/res/res_crypto.c <span style="color: grey">(429611)</span></li>
<li>/branches/11/res/pjproject/pjnath/src/pjnath/turn_sock.c <span style="color: grey">(429611)</span></li>
<li>/branches/11/res/pjproject/pjnath/src/pjnath/stun_msg_dump.c <span style="color: grey">(429611)</span></li>
<li>/branches/11/res/pjproject/pjnath/src/pjnath/stun_msg.c <span style="color: grey">(429611)</span></li>
<li>/branches/11/res/pjproject/pjnath/src/pjnath-test/stun.c <span style="color: grey">(429611)</span></li>
<li>/branches/11/res/pjproject/pjlib/src/pj/ssl_sock_dump.c <span style="color: grey">(429611)</span></li>
<li>/branches/11/res/pjproject/pjlib-util/src/pjlib-util-test/encryption.c <span style="color: grey">(429611)</span></li>
<li>/branches/11/pbx/dundi-parser.c <span style="color: grey">(429611)</span></li>
<li>/branches/11/main/utils.c <span style="color: grey">(429611)</span></li>
<li>/branches/11/main/udptl.c <span style="color: grey">(429611)</span></li>
<li>/branches/11/main/netsock.c <span style="color: grey">(429611)</span></li>
<li>/branches/11/main/manager.c <span style="color: grey">(429611)</span></li>
<li>/branches/11/main/loader.c <span style="color: grey">(429611)</span></li>
<li>/branches/11/channels/vcodecs.c <span style="color: grey">(429611)</span></li>
<li>/branches/11/channels/sig_pri.c <span style="color: grey">(429611)</span></li>
<li>/branches/11/channels/misdn/ie.c <span style="color: grey">(429611)</span></li>
<li>/branches/11/channels/iax2-parser.c <span style="color: grey">(429611)</span></li>
<li>/branches/11/channels/chan_unistim.c <span style="color: grey">(429611)</span></li>
<li>/branches/11/channels/chan_sip.c <span style="color: grey">(429611)</span></li>
<li>/branches/11/channels/chan_misdn.c <span style="color: grey">(429611)</span></li>
<li>/branches/11/channels/chan_iax2.c <span style="color: grey">(429611)</span></li>
<li>/branches/11/channels/chan_h323.c <span style="color: grey">(429611)</span></li>
<li>/branches/11/apps/app_sms.c <span style="color: grey">(429611)</span></li>
<li>/branches/11/apps/app_osplookup.c <span style="color: grey">(429611)</span></li>
<li>/branches/11/apps/app_getcpeid.c <span style="color: grey">(429611)</span></li>
<li>/branches/11/apps/app_adsiprog.c <span style="color: grey">(429611)</span></li>
<li>/branches/11/addons/ooh323c/src/printHandler.c <span style="color: grey">(429611)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4263/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>