<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4248/">https://reviewboard.asterisk.org/r/4248/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Joshua Colp.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The chan_pjsip module currently sends a BYE when a channel is hung up without any regard to an active INVITE transaction. While the PJSIP stack will allow this to happen the remote client may end up receiving a re-INVITE and a BYE at nearly the same time. Some implementations tolerate this while others do not. This would occur if two channels were in a bridge using bridge_native_rtp with direct media and one hung up.
This change makes it so if there is an outstanding INVITE transaction the BYE is queued so it will occur when the transaction has completed (be it normally or timeout).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manually tested and confirmed the behavior executes.
Ran directmedia transfer tests and confirmed they were written to take this behavior into account. After fixing the behavior they were broken and are fixed in another review.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/12/res/res_pjsip_session.exports.in <span style="color: grey">(429349)</span></li>
<li>/branches/12/res/res_pjsip_session.c <span style="color: grey">(429349)</span></li>
<li>/branches/12/include/asterisk/res_pjsip_session.h <span style="color: grey">(429349)</span></li>
<li>/branches/12/channels/chan_pjsip.c <span style="color: grey">(429349)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4248/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>