<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4231/">https://reviewboard.asterisk.org/r/4231/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Mark Michelson.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-24554">ASTERISK-24554</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently, there is an event that occurs when Caller ID on a channel changes (NewCallerid for AMI, ChannelCallerId for ARI). This change implements a similar event when a channel's connected line changes (NewConnectedLine for AMI, ChannelConnectedLine for ARI).
This change is proposed for Asterisk 13 since it is not very invasive and has accompanying tests.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">See /r/4232 for some automated tests.
I also performed calls between multiple parties to ensure that in typical bridging scenarios, the events were emitted.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/13/rest-api/api-docs/events.json <span style="color: grey">(428835)</span></li>
<li>/branches/13/res/stasis/app.c <span style="color: grey">(428835)</span></li>
<li>/branches/13/res/ari/ari_model_validators.c <span style="color: grey">(428835)</span></li>
<li>/branches/13/res/ari/ari_model_validators.h <span style="color: grey">(428835)</span></li>
<li>/branches/13/main/stasis_channels.c <span style="color: grey">(428835)</span></li>
<li>/branches/13/main/manager_channels.c <span style="color: grey">(428835)</span></li>
<li>/branches/13/main/channel.c <span style="color: grey">(428835)</span></li>
<li>/branches/13/include/asterisk/stasis_channels.h <span style="color: grey">(428835)</span></li>
<li>/branches/13/CHANGES <span style="color: grey">(428835)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4231/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>