<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4145/">https://reviewboard.asterisk.org/r/4145/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 4th, 2014, 4:53 p.m. CST, <b>Mark Michelson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why the change to being a standalone script? I personally like the idea of it being a filter more.</pre>
</blockquote>
<p>On November 4th, 2014, 5:50 p.m. CST, <b>George Joseph</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I changed it locally months back for 2 reasons...
The first was that runtests wasn't pre-calculating and printing the total number of tests to run back then. So I had to run runtests twice, once to get the total number (in dry-run mode) then again for real.
The other one was buffering problems. ./runtests.py | pretty_print wasn't printing output as often as it should so I was always doing
python -u ./runtests.py | pretty_print.
Honestly, I didn't think anyone else was using it. :)
I can change it back to a filter if that's more useful.
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Now that I know it exists I'm going to be using it more often :-)
Personally, I like that it is a filter. I think that's kinda helpful - and the outpupt is certainly much nicer to look at then the current output from runtests when just running a subset of tests.
We could modify runtests.py to output things unbuffered (or possibly to unbuffer things with a particular command line switch) - something like this perhaps:
http://stackoverflow.com/questions/881696/unbuffered-stdout-in-python-as-in-python-u-from-within-the-program</pre>
<br />
<p>- Matt</p>
<br />
<p>On November 3rd, 2014, 9:43 a.m. CST, George Joseph wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By George Joseph.</div>
<p style="color: grey;"><i>Updated Nov. 3, 2014, 9:43 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Updated contrib/scripts/pretty_print so it works with recent runtests.py changes. Also changed it from a filter to a standalone script.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>asterisk/trunk/contrib/scripts/pretty_print <span style="color: grey">(5878)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4145/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>