<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4107/">https://reviewboard.asterisk.org/r/4107/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 29th, 2014, 10:07 p.m. UTC, <b>Kevin Harwell</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"Configuring res_pjsip for Presence Subscriptions"
Under the "Configuration" section, 3rd paragraph, the "context" option description - (just to be sure) the subscribing endpoint's context must be set to that of the hint?
-------------------------------------------------------------
"Resource List Subscriptions (RLS)"
Under "Batching Notifications", 1st paragraph the following sentence fragment sounds a little strange: ..."any further state changes of states in the list ..."
-------------------------------------------------------------
"Configuring Outbound Registrations"
Under the "Authentication" last sentence: "Details about what options are available in auth sections can be found here." <-- I'm guessing "here" was meant to be a link?
Also, the "Authentication" section is under "Dealing with Failure". I'd probably move the "Dealing with Failure" section below the "Authentication" part.
Under "Manually Unregistering" I'd probably add a note that after manually unregistering the specified outbound registration will continue attempting re-registers based on it last registration expiration.
-------------------------------------------------------------
"Asterisk PJSIP Troubleshooting Guide"
There is a gap between the "Overview" section and the next. Can this be shrunk or is it due to some kind of wiki formatting "thing"?
Personally, I'd lean toward breaking the troubleshooting guide into sub-pages. Especially if you think more will be added later as things come up. Breaking things up would certainly make it easier to find a particular section when navigating via the content tree.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've addressed everything here except breaking the troubleshooting page up. I think that breaking it up is a good idea if the page starts to grow larger than it is right now. For the time being, the table of contents at the top of the page makes navigation reasonable.
</pre>
<br />
<p>- Mark</p>
<br />
<p>On October 22nd, 2014, 9:37 p.m. UTC, Mark Michelson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Mark Michelson.</div>
<p style="color: grey;"><i>Updated Oct. 22, 2014, 9:37 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have written the following wiki pages:
https://wiki.asterisk.org/wiki/display/AST/Configuring+res_pjsip+for+Presence+Subscriptions
https://wiki.asterisk.org/wiki/pages/viewpage.action?pageId=30278158
https://wiki.asterisk.org/wiki/display/AST/Configuring+Outbound+Registrations
https://wiki.asterisk.org/wiki/display/AST/Asterisk+PJSIP+Troubleshooting+Guide
The first three pages are tutorial pages for Asterisk PJSIP usage. The first focuses on setting up presence subscriptions, the second focuses on setting up resource list subscriptions, and the third focuses on configuring outbound registrations.
The fourth page is a general PJSIP troubleshooting guide. The intent of this page is not to be exhaustive at the moment, since this is a page that likely will be updated frequently as specific issues are encountered. This page may need to be split into multiple pages, but I'll leave that judgment to the reviewers.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4107/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>