<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/4062/">https://reviewboard.asterisk.org/r/4062/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can you make the change in res_pjsip_phoneprov_provider while you're there?  It was just committed.  It'd need CHECK_PJSIP_MODULE_LOADED().</pre>
 <br />









<p>- George Joseph</p>


<br />
<p>On October 9th, 2014, 8:30 a.m. MDT, opticron wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By opticron.</div>


<p style="color: grey;"><i>Updated Oct. 9, 2014, 8:30 a.m.</i></p>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-24312">ASTERISK-24312</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This enforces that res_pjsip, res_pjsip_session, and res_pjsip_pubsub have loaded properly before attempting to load any modules that depend on them since the module loader system is not currently capable of resolving module dependencies on its own.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Verified that this fixed the bug presented in ASTERISK-24312.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>branches/12/res/res_pjsip_xpidf_body_generator.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_transport_websocket.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_t38.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_session.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_send_to_voicemail.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_sdp_rtp.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_rfc3326.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_registrar_expire.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_registrar.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_refer.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_pubsub.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_pidf_eyebeam_body_supplement.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_pidf_digium_body_supplement.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_pidf_body_generator.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_path.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_outbound_registration.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_outbound_authenticator_digest.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_one_touch_record_info.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_notify.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_nat.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_mwi_body_generator.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_mwi.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_multihomed.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_messaging.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_logger.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_header_funcs.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_exten_state.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_endpoint_identifier_user.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_endpoint_identifier_ip.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_endpoint_identifier_anonymous.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_dtmf_info.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_diversion.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_dialog_info_body_generator.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_caller_id.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_authenticator_digest.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_pjsip_acl.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/res/res_hep_pjsip.c <span style="color: grey">(424849)</span></li>

 <li>branches/12/include/asterisk/res_pjsip_session.h <span style="color: grey">(424849)</span></li>

 <li>branches/12/include/asterisk/res_pjsip_pubsub.h <span style="color: grey">(424849)</span></li>

 <li>branches/12/include/asterisk/res_pjsip.h <span style="color: grey">(424849)</span></li>

 <li>branches/12/channels/chan_pjsip.c <span style="color: grey">(424849)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/4062/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>