<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4055/">https://reviewboard.asterisk.org/r/4055/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By wdoekes.</div>
<p style="color: grey;"><i>Updated Oct. 12, 2014, 3:25 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Committed in revision 5715</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22791">ASTERISK-22791</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ASTERISK-22791 details how asterisk resends a reINVITE even though the
call has already been hung up by a BYE.
This tests that problem.
Also note how the From/To are also reversed, since this is a reINVITE
*to* alice where alice is in the From.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Before it is fixed:
<?xml version="1.0" encoding="utf-8"?>
<testsuite errors="0" failures="1" name="AsteriskTestSuite" tests="1" time="2.84">
<testcase name="tests/channels/SIP/no_reinvite_after_491" time="2.84">
<failure>Running ['./lib/python/asterisk/test_runner.py', 'tests/channels/SIP/no_reinvite_after_491'] ...
[Oct 08 17:54:30] WARNING[4582]: sipp:437 processEnded: Resolving remote host '127.0.0.1'... Done.
[Oct 08 17:54:30] WARNING[4582]: sipp:437 processEnded: 2014-10-08 17:54:30.202158 1412783670.202158: Aborting call on unexpected message for Call-Id '1-4636@127.0.0.1': while pausing (index 10), received 'INVITE sip:alice@127.0.0.1:5062 SIP/2.0
Via: SIP/2.0/UDP 127.0.0.1:5060;branch=z9hG4bK717504e3;rport
Max-Forwards: 70
From: alice <sip:alice@127.0.0.1:5062>;tag=4636SIPpTag001
To: bob <sip:bob@127.0.0.1:5060>;tag=as7d7023cd
Contact: <sip:bob@127.0.0.1:5060>
Call-ID: 1-4636@127.0.0.1
CSeq: 103 INVITE
User-Agent: Asterisk PBX SVN-branch-1.8-r424181
Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, REFER, SUBSCRIBE, NOTIFY, INFO, PUBLISH, MESSAGE
Supported: replaces, timer
X-asterisk-Info: SIP re-invite (External RTP bridge)
Content-Type: application/sdp
Content-Length: 296
v=0
o=root 30542954 30542956 IN IP4 127.0.0.1
s=Asterisk PBX SVN-branch-1.8-r424181
c=IN IP4 127.0.0.1
t=0 0
m=image 4725 udptl t38
c=IN IP4 127.0.0.1
a=T38FaxVersion:0
a=T38MaxBitRate:14400
a=T38FaxRateManagement:transferredTCF
a=T38FaxMaxDatagram:389
a=T38FaxUdpEC:t38UDPRedundancy
'.
[Oct 08 17:54:30] WARNING[4582]: sipp:539 __scenario_callback: SIPp Scenario alice.xml Failed [1]
[Oct 08 17:54:30] WARNING[4582]: sipp:548 __evaluate_scenario_results: SIPp Scenario alice.xml Failed
[Oct 08 17:54:30] WARNING[4582]: sipp:402 kill: Killing SIPp Scenario bob.xml
</failure>
</testcase>
</testsuite>
After a possible fix:
<?xml version="1.0" encoding="utf-8"?>
<testsuite errors="0" failures="0" name="AsteriskTestSuite" tests="1" time="9.95">
<testcase name="tests/channels/SIP/no_reinvite_after_491" time="9.95"/>
</testsuite></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/channels/SIP/tests.yaml <span style="color: grey">(5684)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/no_reinvite_after_491/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/no_reinvite_after_491/sipp/bob.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/no_reinvite_after_491/sipp/alice.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/no_reinvite_after_491/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/no_reinvite_after_491/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4055/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>