<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4015/">https://reviewboard.asterisk.org/r/4015/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The following do not compile when MALLOC_DEBUG is enabled with this patch:
channels/h323/ast_h323.cxx (Used by chan_h323.c)
addons/chan_ooh323.c
addons/mp3/interface.c (Used by format_mp3.c) This file is problematic as it is not included in with the asterisk source itself for licensing reasons.
The following do not compile when MALLOC_DEBUG is not enabled with this patch:
main/tdd.c
The part of this patch that prevents compiling is a breaking change and affects third party modules compiling. Not good. What remains is essentially just a cosmetic change and due to its size should just be done on trunk.</pre>
<br />
<p>- rmudgett</p>
<br />
<p>On September 22nd, 2014, 1:55 p.m. CDT, wdoekes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By wdoekes.</div>
<p style="color: grey;"><i>Updated Sept. 22, 2014, 1:55 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-24348">ASTERISK-24348</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">After having a bit of an issue with free() being defined as ast_free()
without it being obvious, as can be seen here
http://lists.digium.com/pipermail/asterisk-commits/2014-September/070353.html ,
I decided to abolish the use of free() (without ast_-prefix) wherever
reasonably possible.
The diff speaks for itself.
I added the define WRAP_LIBC_MALLOC to allow free() to mean ast_free()
and so on. See this:
https://reviewboard.asterisk.org/r/4015/diff/#28
If that is *not* defined, and "asterisk.h" is included, then free()
and friends will throw compile errors like this:
mpool/mpool.c:291:3: error: implicit declaration of function
‘Do_not_use_free__use_ast_free_or_ast_std_free_for_remotely_allocated_memory’
[-Werror=implicit-function-declaration]
That variable is defined for the cases where either STANDALONE
behaviour is expected (utils stuff) or code is autogenerated (lexer stuff).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It compiles.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/1.8/utils/extconf.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/tests/test_dlinklists.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/res/res_smdi.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/res/res_rtp_asterisk.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/res/res_pktccops.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/res/res_phoneprov.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/res/res_config_ldap.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/res/ais/evt.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/res/ael/pval.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/res/ael/ael_lex.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/res/ael/ael.y <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/res/ael/ael.tab.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/res/ael/ael.flex <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/pbx/pbx_config.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/main/utils.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/main/tdd.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/main/loader.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/main/hashtab.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/main/file.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/main/db1-ast/mpool/mpool.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/main/channel.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/main/autoservice.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/main/ast_expr2f.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/main/ast_expr2.y <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/main/ast_expr2.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/main/app.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/main/acl.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/include/asterisk/threadstorage.h <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/include/asterisk/astmm.h <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/funcs/func_curl.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/channels/chan_skinny.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/channels/chan_mgcp.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/channels/chan_jingle.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/channels/chan_gtalk.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/channels/chan_console.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/cel/cel_tds.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/apps/app_stack.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/apps/app_queue.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/apps/app_jack.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/addons/chan_ooh323.c <span style="color: grey">(423656)</span></li>
<li>/branches/1.8/addons/app_mysql.c <span style="color: grey">(423656)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4015/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>