<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4014/">https://reviewboard.asterisk.org/r/4014/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Matt Jordan.</div>
<div>By Mark Michelson.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In Asterisk 13, the format rewrite caused CDR and CEL unit tests to have FRACKs because they have no formats on the channels they create. In revision 423414 of Asterisk 13, I introduced an independent change that is intended to prevent unnecessary FRACKs by returning early when attempting to set up translation paths if any channel has no formats set. Unfortunately, this resulted in huge breakage of the CDR and CEL unit tests.
The change introduced in this review is to set the ulaw format on channels created by the CEL and CDR unit tests. This way, the tests are passing again. Event better, they now pass FRACK-free.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran CDR and CEL unit tests with and without the change. Without this patch, things are pretty disastrous in the CEL tests (i.e. Asterisk crashes). And the CDR tests have FRACKs in them. With the patch, all CDR and CEL unit tests pass with no FRACKs.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/13/tests/test_cel.c <span style="color: grey">(423656)</span></li>
<li>/branches/13/tests/test_cdr.c <span style="color: grey">(423656)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4014/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>