<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Sat, Sep 20, 2014 at 3:13 PM, Joshua Colp <span dir="ltr"><<a href="mailto:jcolp@digium.com" target="_blank" onclick="window.open('https://mail.google.com/mail/?view=cm&tf=1&to=jcolp@digium.com&cc=&bcc=&su=&body=','_blank','location=yes,menubar=yes,resizable=yes,width=800,height=600');return false;">jcolp@digium.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">George Joseph wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
On Sat, Sep 20, 2014 at 2:20 PM, Joshua Colp <<a href="mailto:jcolp@digium.com" target="_blank" onclick="window.open('https://mail.google.com/mail/?view=cm&tf=1&to=jcolp@digium.com&cc=&bcc=&su=&body=','_blank','location=yes,menubar=yes,resizable=yes,width=800,height=600');return false;">jcolp@digium.com</a><br>
<mailto:<a href="mailto:jcolp@digium.com" target="_blank" onclick="window.open('https://mail.google.com/mail/?view=cm&tf=1&to=jcolp@digium.com&cc=&bcc=&su=&body=','_blank','location=yes,menubar=yes,resizable=yes,width=800,height=600');return false;">jcolp@digium.com</a>>> wrote:<br>
<br>
George Joseph wrote:<br>
<br>
<snip><br>
<br>
<br>
I was thinking that we probably don't want to create hard coded<br>
objects<br>
called "trunk", "user", etc. Instead let the user define the<br>
patterns<br>
that suit them.<br>
<br>
<br>
It would be much more approachable for a user with specific types.<br>
<br>
<br>
Is this agreement on letting the user define the patterns (with samples<br>
provides) or are you saying we should hardcode types? There are enough<br>
variations in the patterns that I don't think we could create viable<br>
'trunk', 'user', etc. objects. I'd make this a separate config<br>
(pjsip_express.conf or something) with a default set of pattern definitions.<br>
</blockquote>
<br>
I'm saying for making it easier to configure PJSIP for users there could be hardcoded types which represent the common types that users need. If more control is required than the lower level detailed ones can be used. It is certainly possible to have 'phone' and 'trunk' types which are useful for a good percentage.<br>
<br>
Your pattern idea I would say is an alternative way for doing it, but is still more complicated than distinct types and requires explanation.<br></blockquote><div><br></div><div>How about we use the pattern approach but compile in patterns for trunk and user. There are lots of minor differences between ITSPs and phones and I just worry that in the quest to create something for everyone we create something that's useful to no one. </div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
Given the following (even without documentation) could someone coming from sip.conf understand it?<br>
<br>
[1000]<br>
type=phone<br>
secret=notverysecret<br>
context=trusted<br>
disallow=all<br>
allow=g722<br>
mailbox=1000<br>
<br>
I err on the side of yes. That's what I think is needed. Heck, it's hard enough to get people to realize they can use templates.<span><font color="#888888"><br>
<br></font></span></blockquote><div>I love templates so much that I enhanced manager and config so you read and write templates via AMI GetConfig and UpdateConfig.</div><div><br></div><div>If we compile in basic patterns it could be as simple as </div><div><br></div><div><div style="font-family:arial,sans-serif;font-size:12.8000001907349px"><font size="1" face="courier new, monospace">[1000]</font></div><div style="font-family:arial,sans-serif;font-size:12.8000001907349px"><font size="1" face="courier new, monospace">type = composite ; ok, maybe composite and pattern aren't good names.</font></div><div style="font-family:arial,sans-serif;font-size:12.8000001907349px"><font size="1" face="courier new, monospace">pattern = phone ; built-in pattern</font></div><div style="font-family:arial,sans-serif;font-size:12.8000001907349px"><span style="font-family:'courier new',monospace;font-size:x-small">incoming_password = notverysecret</span><br></div></div><div style="font-family:arial,sans-serif;font-size:12.8000001907349px"><font size="1" face="courier new, monospace">context = trusted</font></div><div style="font-family:arial,sans-serif;font-size:12.8000001907349px"><font size="1" face="courier new, monospace">disallow = all</font></div><div style="font-family:arial,sans-serif;font-size:12.8000001907349px"><font size="1" face="courier new, monospace">allow = g722</font></div><div style="font-family:arial,sans-serif;font-size:12.8000001907349px"><font size="1" face="courier new, monospace">mailboxes = 1000</font></div><div style="font-family:arial,sans-serif;font-size:12.8000001907349px"><br></div><div style="font-family:arial,sans-serif;font-size:12.8000001907349px"><br></div><div>Are you OK with a separate config file? It would make manipulating it easier since there'd be no duplicate section names. </div><div><br></div><div><br></div><div><br></div><div> </div></div></div></div>