<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/3971/">https://reviewboard.asterisk.org/r/3971/</a>
     </td>
    </tr>
   </table>
   <br />











<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://reviewboard.asterisk.org/r/3971/diff/1/?file=67190#file67190line118" style="color: black; font-weight: bold; text-decoration: underline;">/branches/1.8/contrib/scripts/refcounter.py</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">def process_file(options):</pre></td>

  </tr>
 </tbody>



 
 

 <tbody>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">99</font></th>
    <td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">            <span class="k">if</span> <span class="n">current_objects</span><span class="p">[</span><span class="n">obj</span><span class="p">][</span><span class="s">'curcount'</span><span class="p">]</span> <span class="o">==</span> <span class="mi">0</span><span class="p">:</span></pre></td>
    <th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">118</font></th>
    <td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">            <span class="k">if</span> <span class="n">current_objects</span><span class="p">[</span><span class="n">obj</span><span class="p">][</span><span class="s">'curcount'</span><span class="p">]</span> <span class="o">==</span> <span class="mi">0</span><span class="p">:</span></pre></td>
  </tr>

 </tbody>


 
 

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">100</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">                <span class="k">if</span> <span class="n">options</span><span class="o">.</span><span class="n">normal</span><span class="p">:</span></pre></td>
    <th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">119</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">                <span class="k">if</span> <span class="n">options</span><span class="o">.</span><span class="n">normal</span><span class="hl"> </span><span class="ow"><span class="hl">and</span></span><span class="hl"> </span><span class="s"><span class="hl">'invalid'</span></span><span class="hl"> </span><span class="ow"><span class="hl">not</span></span><span class="hl"> </span><span class="ow"><span class="hl">in</span></span><span class="hl"> </span><span class="n"><span class="hl">parsed_line</span></span><span class="p"><span class="hl">[</span></span><span class="s"><span class="hl">'state'</span></span><span class="p"><span class="hl">]</span>:</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This can be optimized if invalid objects are given curcount == -1, that way it wouldn't have to do substring comparison again.</pre>
</div>
<br />



<p>- Corey Farrell</p>


<br />
<p>On September 2nd, 2014, 10:22 p.m. EDT, rmudgett wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By rmudgett.</div>


<p style="color: grey;"><i>Updated Sept. 2, 2014, 10:22 p.m.</i></p>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://issues.asterisk.org/jira/browse/AFS-155">AFS-155</a>, 

 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-24295">ASTERISK-24295</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Make astob2 REF_DEBUG output an invalid object line when an invalid ao2 object ref/unref is attempted.  This is similar to the constructor/destructor lines.

* Fixed refcounter.py to handle skewed objects that have constructor/destructor states.

* Made refcounter.py highlight the invalid ao2 object refs by putting them in their own section of the processed output file.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Instigated a REF_DEBUG log that reffed destroyed objects to get an invalid line in the ref debug log file.
The patched script doesn't have an excpetion on a previous invalid ref debug log that had code unreffing a destroyed object.
The patched script now highlights the invalid objects in the log.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/branches/1.8/main/astobj2.c <span style="color: grey">(422535)</span></li>

 <li>/branches/1.8/contrib/scripts/refcounter.py <span style="color: grey">(422535)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/3971/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>