<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3924/">https://reviewboard.asterisk.org/r/3924/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 5th, 2014, 4:40 p.m. CDT, <b>Scott Griepentrog</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm getting errors with this patch running certain manager tests such as mixmonitor. They don't happen without the patch on the same machine.
--> Running test 'tests/manager/mixmonitor' ...
Making sure Asterisk isn't running ...
Making sure SIPp isn't running...
Running ['./lib/python/asterisk/test_runner.py', 'tests/manager/mixmonitor'] ...
Traceback (most recent call last):
File "./lib/python/asterisk/test_runner.py", line 319, in <module>
sys.exit(main() or 0)
File "./lib/python/asterisk/test_runner.py", line 305, in main
load_test_modules(test_config, test_object, ast_version)
File "./lib/python/asterisk/test_runner.py", line 120, in load_test_modules
module_type = load_and_parse_module(module_spec['typename'])
File "./lib/python/asterisk/test_runner.py", line 176, in load_and_parse_module
module = __import__(module_name)
File "/home/sgriepentrog/rb3924/testsuite-patched/lib/python/asterisk/ami.py", line 16, in <module>
import pluggable_modules
File "/home/sgriepentrog/rb3924/testsuite-patched/lib/python/asterisk/pluggable_modules.py", line 17, in <module>
from ami import AMIEventInstance
ImportError: cannot import name AMIEventInstance
Exception occurred while archiving logs from /tmp/asterisk-testsuite/manager/mixmonitor/run_1/ast1/var/log/asterisk to ./logs/manager/mixmonitor/run_1/ast1/var/log/asterisk: [Errno 2] No such file or directory
Test ['./lib/python/asterisk/test_runner.py', 'tests/manager/mixmonitor', 'SVN-trunk-r422647'] failed
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I seem to have created an import loop. I'll break out things causing this.</pre>
<br />
<p>- opticron</p>
<br />
<p>On August 19th, 2014, 9:32 p.m. CDT, opticron wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By opticron.</div>
<p style="color: grey;"><i>Updated Aug. 19, 2014, 9:32 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This adds a modular event/action system that can handle routing from arbitrary events to arbitrary actions allowing creation of more flexible tests. This includes event modules for AMI and ARI actions as well as action modules for AMI, ARI, callbacks, and more.
This also converts three tests as a proof of concept.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran the tests and verified that events and actions were triggering properly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>asterisk/trunk/tests/rest_api/bridges/bridge_by_id/test-config.yaml <span style="color: grey">(5409)</span></li>
<li>asterisk/trunk/tests/rest_api/bridges/attended_transfer/test-config.yaml <span style="color: grey">(5409)</span></li>
<li>asterisk/trunk/tests/rest_api/bridges/attended_transfer/attended_transfer.py <span style="color: grey">(5409)</span></li>
<li>asterisk/trunk/tests/asyncagi/asyncagi_break/test-config.yaml <span style="color: grey">(5409)</span></li>
<li>asterisk/trunk/tests/asyncagi/asyncagi_break/asyncagi_break.py <span style="color: grey">(5409)</span></li>
<li>asterisk/trunk/lib/python/asterisk/pluggable_registry.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/lib/python/asterisk/pluggable_modules.py <span style="color: grey">(5409)</span></li>
<li>asterisk/trunk/lib/python/asterisk/ari.py <span style="color: grey">(5409)</span></li>
<li>asterisk/trunk/lib/python/asterisk/ami.py <span style="color: grey">(5409)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3924/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>