<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3917/">https://reviewboard.asterisk.org/r/3917/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Jonathan Rose.</div>
<p style="color: grey;"><i>Updated Aug. 19, 2014, 11:21 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Committed in revision 421416</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-24043">ASTERISK-24043</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Steps for reproduction:
* one extension in dial plan
[default]
exten => 1000,1,NoOp(Show me something running in verbosity 3 please)
* Start a websocket listening for a stasis application
I use the websocket echo test to listen for application 'hello'
* Use the command POST /channels to call an endpoint and put it into stasis
I used the args endpoint='SIP/1601', app='hello', channelID='test'
* Use the POST /channels/{channelID}/continue command to make the channel
continue into the PBX I used the args channelID='test', context='default',
extension='1000', priority=1
Expectations:
* The channel should leave stasis and start a new life in the PBX. Or to
simplify, I should see a StasisEnd event on the websocket and I should see
extension 1000 executing on the SIP/1601-xxxxxxxx channel since I run at
verbosity 3.
Actual results prior to the patch:
* StasisEnd is received, but the channel never enters the PBX and I don't
see my NoOp application being ran.
The patch solves this problem by calling ast_pbx_run_args on the channel
before it would leave the stasis_app_exec function when there isn't a PBX
running on the channel and when the channel isn't hung up.
Patch: stasis-continue.diff submitted by Krandon Bruze</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran through reproduction with and without patch to confirm that the issue existed and that the patch fixes the issue.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/12/res/res_stasis.c <span style="color: grey">(421079)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3917/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>