<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3823/">https://reviewboard.asterisk.org/r/3823/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Corey Farrell.</div>
<div>By opticron.</div>
<p style="color: grey;"><i>Updated Aug. 5, 2014, 9:46 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use the new enum instead of magic numbers.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This introduces stasis.conf and a mechanism to prevent certain message types from being published.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested by causing the stasis unittests to fail with the following stasis.conf configuration:
[declined_message_types]
decline=TestMessage</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/tests/test_stasis_channels.c <span style="color: grey">(420027)</span></li>
<li>trunk/tests/test_stasis.c <span style="color: grey">(420027)</span></li>
<li>trunk/res/res_stun_monitor.c <span style="color: grey">(420027)</span></li>
<li>trunk/res/res_stasis_test.c <span style="color: grey">(420027)</span></li>
<li>trunk/res/res_stasis_snoop.c <span style="color: grey">(420027)</span></li>
<li>trunk/res/res_stasis.c <span style="color: grey">(420027)</span></li>
<li>trunk/res/res_corosync.c <span style="color: grey">(420027)</span></li>
<li>trunk/res/parking/parking_manager.c <span style="color: grey">(420027)</span></li>
<li>trunk/pbx/pbx_realtime.c <span style="color: grey">(420027)</span></li>
<li>trunk/main/test.c <span style="color: grey">(420027)</span></li>
<li>trunk/main/stasis_system.c <span style="color: grey">(420027)</span></li>
<li>trunk/main/stasis_message.c <span style="color: grey">(420027)</span></li>
<li>trunk/main/stasis_endpoints.c <span style="color: grey">(420027)</span></li>
<li>trunk/main/stasis_channels.c <span style="color: grey">(420027)</span></li>
<li>trunk/main/stasis_cache.c <span style="color: grey">(420027)</span></li>
<li>trunk/main/stasis_bridges.c <span style="color: grey">(420027)</span></li>
<li>trunk/main/stasis.c <span style="color: grey">(420027)</span></li>
<li>trunk/main/security_events.c <span style="color: grey">(420027)</span></li>
<li>trunk/main/rtp_engine.c <span style="color: grey">(420027)</span></li>
<li>trunk/main/presencestate.c <span style="color: grey">(420027)</span></li>
<li>trunk/main/pickup.c <span style="color: grey">(420027)</span></li>
<li>trunk/main/named_acl.c <span style="color: grey">(420027)</span></li>
<li>trunk/main/manager.c <span style="color: grey">(420027)</span></li>
<li>trunk/main/loader.c <span style="color: grey">(420027)</span></li>
<li>trunk/main/file.c <span style="color: grey">(420027)</span></li>
<li>trunk/main/endpoints.c <span style="color: grey">(420027)</span></li>
<li>trunk/main/devicestate.c <span style="color: grey">(420027)</span></li>
<li>trunk/main/core_local.c <span style="color: grey">(420027)</span></li>
<li>trunk/main/channel.c <span style="color: grey">(420027)</span></li>
<li>trunk/main/cdr.c <span style="color: grey">(420027)</span></li>
<li>trunk/main/ccss.c <span style="color: grey">(420027)</span></li>
<li>trunk/main/bridge.c <span style="color: grey">(420027)</span></li>
<li>trunk/main/app.c <span style="color: grey">(420027)</span></li>
<li>trunk/include/asterisk/stasis.h <span style="color: grey">(420027)</span></li>
<li>trunk/funcs/func_cdr.c <span style="color: grey">(420027)</span></li>
<li>trunk/configs/samples/stasis.conf.sample <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/apps/app_queue.c <span style="color: grey">(420027)</span></li>
<li>trunk/apps/app_forkcdr.c <span style="color: grey">(420027)</span></li>
<li>trunk/apps/app_chanspy.c <span style="color: grey">(420027)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3823/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>