<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3811/">https://reviewboard.asterisk.org/r/3811/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Corey Farrell.</div>
<p style="color: grey;"><i>Updated Aug. 1, 2014, 6:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Fix build_tools/get_documentation so it picks up all DOCUMENTATION blocks from each file
* Use .to_ami callbacks for most events
* Reorder stasis_channels.c / stasis_bridges.c so that callbacks are immediately preceding the STASIS_MESSAGE_TYPE_DEFN declaration.
* Scatter DOCUMENATION blocks to be next to the code that they are documenting. This will make it easier to see discrepancies between documentation and code.
* Add missing <managerEvent> tags throughout code, as well as "class" attribute missing from managerEventInstance. This was needed to deal with the fact that doc/core-en_US.xml now contains documentation that was previously missed.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-24068">ASTERISK-24068</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This change moves main/manager_*.c to loadable modules, allowing those events to be disabled by not loading the modules. This can be accomplished by eventfilter, but eventfilter has a couple issues. It actually adds more overhead to asterisk since the outbound events must be parsed for each AMI user. Additionally it causes skips in SequenceNumber, preventing use of that tag to determine if any events were missed during a reconnect.
Besides converting from built-in units to modules, changes are made to VarSet, ChannelTalkingStart and ChannelTalkingStop. They no longer use .to_ami callbacks, but instead subscribe to the stasis events like the rest of the res_manager_channels events. A couple functions were also moved from manager_bridging.c and manager_channels.c to manager.c since they are still needed even if these modules are noload'ed.
AST_MODULE_INFO_STANDARD for all modules will be updated once r3802 is committed. This or r3812 will need to be updated depending on which is committed first.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran some testsuite's to verify some of the events were still being sent to AMI:
tests/manager/originate
tests/apps/channel_redirect
tests/bridge/connected_line_update
tests/feature_call_pickup
tests/apps/dial/dial_answer
tests/apps/chanspy/chanspy_barge
tests/funcs/func_push
This did not provide complete coverage for all effected events, but does verify many events from res_manager_channels.c. Events from other files were not tested, though res_manager_channels.c was the most likely to cause problems.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/res/res_manager_system.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/res/res_manager_mwi.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/res/res_manager_endpoints.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/res/res_manager_channels.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/res/res_manager_bridges.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/main/stasis_channels.c <span style="color: grey">(419804)</span></li>
<li>/trunk/main/stasis_bridges.c <span style="color: grey">(419804)</span></li>
<li>/trunk/main/manager_system.c <span style="color: grey">(419804)</span></li>
<li>/trunk/main/manager_mwi.c <span style="color: grey">(419804)</span></li>
<li>/trunk/main/manager_endpoints.c <span style="color: grey">(419804)</span></li>
<li>/trunk/main/manager_channels.c <span style="color: grey">(419804)</span></li>
<li>/trunk/main/manager_bridges.c <span style="color: grey">(419804)</span></li>
<li>/trunk/main/manager.c <span style="color: grey">(419804)</span></li>
<li>/trunk/main/logger.c <span style="color: grey">(419804)</span></li>
<li>/trunk/main/channel.c <span style="color: grey">(419804)</span></li>
<li>/trunk/include/asterisk/manager.h <span style="color: grey">(419804)</span></li>
<li>/trunk/build_tools/get_documentation <span style="color: grey">(419804)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3811/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>