<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3770/">https://reviewboard.asterisk.org/r/3770/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Samuel Galarneau.</div>
<div>By Matt Jordan.</div>
<p style="color: grey;"><i>Updated July 23, 2014, 11:19 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use max_silence_seconds to determine if we record energy, not max_duration_seconds. +1 to cwolfe for catching that in his test.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-24037">ASTERISK-24037</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds two new fields to the LiveRecording model, duration and energy_duration. duration is the time, in seconds, of the entire recording as reported by the Asterisk core; energy_duration is the time, in seconds, of the recording minus any silence that was detected while recording took place.
This is particularly useful when you want to throw away short recordings or recordings that are all silence.
Example RecordingFinished event:
{
"application":"testsuite",
"type":"RecordingFinished",
"recording":{"state":"done",
"format":"wav",
"name":"superfly",
"duration":5,
"target_uri":"channel:1405289721.1",
"energy_duration":4
}
}</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Testsuite tests will still need to be written for this feature. This will review will be updated once a test has been written that verifies audio + silence + audio along with expected durations.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/12/rest-api/api-docs/recordings.json <span style="color: grey">(419180)</span></li>
<li>/branches/12/res/res_stasis_recording.c <span style="color: grey">(419180)</span></li>
<li>/branches/12/res/ari/ari_model_validators.c <span style="color: grey">(419180)</span></li>
<li>/branches/12/res/ari/ari_model_validators.h <span style="color: grey">(419180)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3770/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>