<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3765/">https://reviewboard.asterisk.org/r/3765/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 13th, 2014, 4:22 p.m. CDT, <b>rmudgett</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ast_assert() already outputs a backtrace using ao2_bt() even if DO_CRACH is not enabled.
We also seem to have two backtrace generation functions:
ao2_bt()
ast_log_bactrace()</pre>
</blockquote>
<p>On July 13th, 2014, 4:52 p.m. CDT, <b>Matt Jordan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We could consolidate these two functions easily; ast_log_backtrace should just use ast_verbose instead of ast_debug.
ast_verbose has a bit more functionality in the logger that works hard to get its output seen - if there are no verbosers registered, it will output to stdout.
I don't think printing out a backtrace should live in ao2.</pre>
</blockquote>
<p>On July 13th, 2014, 6:37 p.m. CDT, <b>rmudgett</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* ao2_bt() exists in v1.8+.
* ast_log_backtrace() exists in v1.8 & v11 as ast_backtrace().
* Neither are referenced in v1.8 and v11 for anything.
* v12+ only uses ao2_bt() for ast_assert()
* Ironically v12+ only uses ast_log_backtrace() in __ao2_ref_debug() before ast_assert(0).
Of course merging them should be done in trunk and maybe v12 with the winner being ast_log_backtrace() using ast_verbose() to log the backtrace.</pre>
</blockquote>
<p>On July 13th, 2014, 7:18 p.m. CDT, <b>Matt Jordan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">At least we are consistently inconsistent!</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is a use of ast_log_backtrace in ast_sip_subscription_notify() in res_pjsip_pubsub.c - is that intentional or leftover debugging?</pre>
<br />
<p>- Scott</p>
<br />
<p>On July 13th, 2014, 3:05 p.m. CDT, Scott Griepentrog wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Scott Griepentrog.</div>
<p style="color: grey;"><i>Updated July 13, 2014, 3:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">On an invalid refcount, rather than just log the message and continue executing normally, provide a backtrace and an assert to stop on DO_CRASH. This can help to catch the first case of an invalid refcount rather than being distracted from the problem with a flurry additional logs from other threads encountering already mangled data.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/main/astobj2.c <span style="color: grey">(418447)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3765/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>