<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3731/">https://reviewboard.asterisk.org/r/3731/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/3731/diff/2-3/?file=62542#file62542line48" style="color: black; font-weight: bold; text-decoration: underline;">team/rmudgett/stasis_linkedids/res/stasis/stasis_bridge.c</a>
<span style="font-weight: normal;">
(Diff revisions 2 - 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">ASTERISK_FILE_VERSION(__FILE__, "$Revision$")</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">48</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="kt">char</span> <span class="o">*</span><span class="n">app_name</span> <span class="o">=</span> <span class="n"><span class="hl">obj</span></span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">48</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="kt">char</span> <span class="o">*</span><span class="n">app_name</span> <span class="o">=</span> <span class="n"><span class="hl">data</span></span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This would be a good place for RAII_VAR() because there are three exits that all ast_free(app_name).</pre>
</div>
<br />
<p>- rmudgett</p>
<br />
<p>On July 10th, 2014, 8:35 a.m. CDT, opticron wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By opticron.</div>
<p style="color: grey;"><i>Updated July 10, 2014, 8:35 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-23941">ASTERISK-23941</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This intercepts channels attempting to enter stasis-controlled bridges that are not themselves controlled by stasis and routes them through Stasis() to be controlled by the Stasis application that controls the channels they are replacing.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested against the updated ARI attended transfer test in https://reviewboard.asterisk.org/r/3732/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>team/rmudgett/stasis_linkedids/rest-api/api-docs/events.json <span style="color: grey">(418321)</span></li>
<li>team/rmudgett/stasis_linkedids/res/stasis/stasis_bridge.c <span style="color: grey">(418321)</span></li>
<li>team/rmudgett/stasis_linkedids/res/stasis/control.c <span style="color: grey">(418321)</span></li>
<li>team/rmudgett/stasis_linkedids/res/stasis/control.h <span style="color: grey">(418321)</span></li>
<li>team/rmudgett/stasis_linkedids/res/stasis/app.c <span style="color: grey">(418321)</span></li>
<li>team/rmudgett/stasis_linkedids/res/stasis/app.h <span style="color: grey">(418321)</span></li>
<li>team/rmudgett/stasis_linkedids/res/res_stasis.c <span style="color: grey">(418321)</span></li>
<li>team/rmudgett/stasis_linkedids/res/ari/ari_model_validators.c <span style="color: grey">(418321)</span></li>
<li>team/rmudgett/stasis_linkedids/res/ari/ari_model_validators.h <span style="color: grey">(418321)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3731/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://reviewboard.asterisk.org/media/uploaded/files/2014/07/10/3331f67f-8c7d-486f-bdcf-bf9a01aa288d__ari_atxfer.diff">Collation of thiis patch and dependency patches.</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>