<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3773/">https://reviewboard.asterisk.org/r/3773/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks fine to me. Should probably throw libmxml-dev into contrib/scripts/install_prereq while you're at it. This also might be a good opportunity to dump mxml altogether as we already use libxml2 in asterisk itself. One less dependency to install.
I'd be happy to take a crack at it if you don't have the bandwidth.</pre>
<br />
<p>- Sean Bright</p>
<br />
<p>On July 14th, 2014, 1:56 a.m. UTC, Matt Jordan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Matt Jordan.</div>
<p style="color: grey;"><i>Updated July 14, 2014, 1:56 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch removes menuselect as a subversion external repo and adds it directly to the Asterisk source. This makes Asterisk substantially more git friendly.
Asterisk is (I think) the only thing that uses menuselect still, as such, keeping menuselect in a separate repository isn't strictly necessary any longer. This patch also goes ahead and makes mxml a required library, removing the need for the mxml repo.
Changes to menuselect were kept at a minimum - however, I opted to copy and add the source files directly rather than attempting any particular svn operation. That does mean we would lose the menuselect history for trunk (13) onwards. I'm not sure how big of a loss that is, given the relative infrequency with which changes are made (and the menuselect history isn't gone, just disconnected...)
The only functional change with this patch: the menuselect UI is no longer run automatically the first time around. I'm not sure how needed (or desired) that is, since make menuselect is always available to configure settings.
Note that menuselect/mxml will continue to exist as separate repos for existing Asterisk branches. We can always choose to backport this patch at some future time to other branches, if the need arises.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/menuselect/test/menuselect-tree <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/menuselect/test/build_tools/menuselect-deps <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/menuselect/strcompat.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/menuselect/missing <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/menuselect/menuselect_stub.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/menuselect/menuselect_newt.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/menuselect/menuselect_gtk.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/menuselect/menuselect_curses.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/menuselect/menuselect.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/menuselect/menuselect.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/menuselect/makeopts.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/menuselect/makeopts <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/menuselect/make_version <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/menuselect/linkedlists.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/menuselect/install-sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/menuselect/example_menuselect-tree <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/menuselect/contrib/menuselect-dummy <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/menuselect/contrib/Makefile-dummy <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/menuselect/configure.ac <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/menuselect/configure <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/menuselect/config.sub <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/menuselect/config.log <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/menuselect/config.guess <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/menuselect/bootstrap.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/menuselect/autoconfig.h.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/menuselect/autoconfig.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/menuselect/aclocal.m4 <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/menuselect/acinclude.m4 <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/menuselect/README <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/menuselect/Makefile <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/include/asterisk/autoconfig.h.in <span style="color: grey">(418565)</span></li>
<li>/trunk/configure.ac <span style="color: grey">(418565)</span></li>
<li>/trunk/configure <span style="color: grey">(UNKNOWN)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3773/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>