<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/3739/">https://reviewboard.asterisk.org/r/3739/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
 <br />









<p>- Corey Farrell</p>


<br />
<p>On July 10th, 2014, 2:20 p.m. EDT, Matt Jordan wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers and Corey Farrell.</div>
<div>By Matt Jordan.</div>


<p style="color: grey;"><i>Updated July 10, 2014, 2:20 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A first pass on removing ao2_bumps on formats assigned to statically allocated frames. With this + opticron's previous patch, I could get a file played back to a Local channel without crashing.

Going to start looking for ref leaks with this patch now.</pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/team/group/media_formats-reviewed-trunk/codecs/codec_resample.c <span style="color: grey">(418348)</span></li>

 <li>/team/group/media_formats-reviewed-trunk/codecs/codec_dahdi.c <span style="color: grey">(418348)</span></li>

 <li>/team/group/media_formats-reviewed-trunk/channels/chan_phone.c <span style="color: grey">(418348)</span></li>

 <li>/team/group/media_formats-reviewed-trunk/channels/chan_misdn.c <span style="color: grey">(418348)</span></li>

 <li>/team/group/media_formats-reviewed-trunk/channels/chan_dahdi.c <span style="color: grey">(418348)</span></li>

 <li>/team/group/media_formats-reviewed-trunk/channels/chan_alsa.c <span style="color: grey">(418348)</span></li>

 <li>/team/group/media_formats-reviewed-trunk/apps/app_sms.c <span style="color: grey">(418348)</span></li>

 <li>/team/group/media_formats-reviewed-trunk/apps/app_nbscat.c <span style="color: grey">(418348)</span></li>

 <li>/team/group/media_formats-reviewed-trunk/apps/app_mp3.c <span style="color: grey">(418348)</span></li>

 <li>/team/group/media_formats-reviewed-trunk/apps/app_milliwatt.c <span style="color: grey">(418348)</span></li>

 <li>/team/group/media_formats-reviewed-trunk/apps/app_jack.c <span style="color: grey">(418348)</span></li>

 <li>/team/group/media_formats-reviewed-trunk/apps/app_festival.c <span style="color: grey">(418348)</span></li>

 <li>/team/group/media_formats-reviewed-trunk/addons/chan_mobile.c <span style="color: grey">(418348)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/3739/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>