<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3738/">https://reviewboard.asterisk.org/r/3738/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, Corey Farrell, Joshua Colp, and Matt Jordan.</div>
<div>By opticron.</div>
<p style="color: grey;"><i>Updated July 10, 2014, 1:17 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Committed in revision 418348</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-23960">ASTERISK-23960</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The format on the frame was being unreffed on static frames that had not bumped the ref resulting in a crash when compiled with the DO_CRASH flag due to the refcount on the format going negative.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ensured that the crash was resolved.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>team/group/media_formats-reviewed-trunk/main/frame.c <span style="color: grey">(418253)</span></li>
<li>team/group/media_formats-reviewed-trunk/include/asterisk/slin.h <span style="color: grey">(418253)</span></li>
<li>team/group/media_formats-reviewed-trunk/codecs/ex_ulaw.h <span style="color: grey">(418253)</span></li>
<li>team/group/media_formats-reviewed-trunk/codecs/ex_speex.h <span style="color: grey">(418253)</span></li>
<li>team/group/media_formats-reviewed-trunk/codecs/ex_lpc10.h <span style="color: grey">(418253)</span></li>
<li>team/group/media_formats-reviewed-trunk/codecs/ex_ilbc.h <span style="color: grey">(418253)</span></li>
<li>team/group/media_formats-reviewed-trunk/codecs/ex_gsm.h <span style="color: grey">(418253)</span></li>
<li>team/group/media_formats-reviewed-trunk/codecs/ex_g726.h <span style="color: grey">(418253)</span></li>
<li>team/group/media_formats-reviewed-trunk/codecs/ex_g722.h <span style="color: grey">(418253)</span></li>
<li>team/group/media_formats-reviewed-trunk/codecs/ex_alaw.h <span style="color: grey">(418253)</span></li>
<li>team/group/media_formats-reviewed-trunk/codecs/ex_adpcm.h <span style="color: grey">(418253)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3738/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>