<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3727/">https://reviewboard.asterisk.org/r/3727/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 8th, 2014, 6:52 p.m. UTC, <b>Corey Farrell</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I just checked, the Makefile optionally includes makeopts. It is only optional so the Makefile can print a nice message that you need to ./configure. This file sets DAHDI_INCLUDE, checking that for non-blank in addition to the check for --prefix would make me very happy. In general people aren't going to install the dahdi development package then choose to not build chan_dahdi.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">DAHDI_INCLUDE gets an empty value on my system (that builds chan_dahdi). I can't see any other way for the makefile to see the result of PBX_DAHDI from autoconf (except a direct sed from build_tools/menuselect-deps).</pre>
<br />
<p>- Tzafrir</p>
<br />
<p>On July 8th, 2014, 3:37 p.m. UTC, Tzafrir Cohen wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Corey Farrell.</div>
<div>By Tzafrir Cohen.</div>
<p style="color: grey;"><i>Updated July 8, 2014, 3:37 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Commit r417863 added support for installing a hook script for dahdi under /usr/share/dahdi/span_config.d . This, however, broke support for users setting --prefix=$HOME:
/usr/bin/install -c -d //usr/share/dahdi/span_config.d
/usr/bin/install: cannot create directory ‘//usr/share/dahdi’: Permission denied
Suggested fix: only install the hook prefix is /usr.
Note: installing only if chan_dahdi was enabled is not easy as menuselect.makeopts is not included into the main Makefile.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/Makefile <span style="color: grey">(418065)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3727/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>