<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3660/">https://reviewboard.asterisk.org/r/3660/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, kmoore and Matt Jordan.</div>
<div>By Jonathan Rose.</div>
<p style="color: grey;"><i>Updated July 3, 2014, 3:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hit kmoore's findings</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">11 part test:
1 - Remove an extension with a priority
If the manager command fails, a failure token will be set
If the original extension runs, a user event will be generated that makes the test fail
2 - Remove an entire existing extension
If the manager command fails, a failure token will be set
If the original extension runs, a user event will be generated that makes the test fail
3 - Add an extension
If the manager command fails, a failure token will be set
If the extension fails to run, an expected user event will not be generated and the test will fail
4 - Add an extension with a CID match that doesn't match the originated channel
If the manager command fails, a failure token will be set
If the extension runs, a user event will be generated that makes the test fail
5 - Add an extension with a CID match that should match the originated channel
If the manager command fails, a failure token will be set
If the extension fails to run, an expected user event will not be generated and the test will fail
6 - Add an extension that replaces an existing priority
If the manager command fails, a failure token will be set
If the original extension runs, a user event will be generated that makes the test fail
If the replacement extension doesn't run, an expected user event will not be generated and the test will fail
7 - Attempt to add an extension that would replace an existing priority, but don't allow replacement
If the manager command doesn't fail, a failure token will be set
If the original extension doesn't run, an expected user event will not be generated and the test will fail
If the replacement extension runs, a user event will be generated that makes the test fail
8 - Remove an extension at a specific priority with caller ID matching
If the manager command fails, a failure token will be set
If the original extension runs, a user event will be generated that makes the test fail
The originate is checked by means of a user event on a separate priority taht is not removed
9 - Attempt DialplanAddExtension without priority set
If the manager command doesn't fail, a failure token will be set
10 - Attempt DialplanAddExtension without application set
If the manager command doesn't fail, a failure token will be set
11 - Attempt DialplanRemoveExtension on an extension that does not exist
If the manager command doesn't fail, a failure token will be set</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removed execution of many of the test AMI commands to guarantee that if above failures occurred that the test would fail</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/pbx/tests.yaml <span style="color: grey">(5204)</span></li>
<li>/asterisk/trunk/tests/pbx/manager_extensions/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/manager_extensions/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/manager_extensions/ami_extension_control.py <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3660/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>