<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jul 1, 2014 at 6:51 AM, Olle E. Johansson <span dir="ltr"><<a href="mailto:oej@edvina.net" target="_blank">oej@edvina.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br><div style="word-wrap:break-word"><br><div><div class=""><div>On 01 Jul 2014, at 13:19, Matthew Jordan <<a href="mailto:mjordan@digium.com" target="_blank">mjordan@digium.com</a>> wrote:</div>
<br><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jul 1, 2014 at 2:25 AM, Olle E. Johansson <span dir="ltr"><<a href="mailto:oej@edvina.net" target="_blank">oej@edvina.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><br>
On 30 Jun 2014, at 16:24, Walter Doekes <<a href="mailto:walter%2Basterisk-dev@osso.nl" target="_blank">walter+asterisk-dev@osso.nl</a>> wrote:<br>
<br>
> On 29-06-14 00:50, Matthew Jordan wrote:<br>
>> * app_readfile/app_dahdibarge/app_setcallerid/app_saycountpl -<br>
>> deprecated in Asterisk 1.8. While less important than the other<br>
>> previously listed modules, having been deprecated for 2 LTS's, it is<br>
>> probably time for these module to go.<br>
><br>
> May I also suggest removing:<br>
><br>
> - SetAMAFlags<br>
> - SetMusicOnHold<br>
> - WaitMusicOnHold<br>
</div>What are the replacements for the musiconhold functions?<br></blockquote><div><br></div><div>From WaitMusicOnHold:<br><br> ast_log(LOG_WARNING, "WaitMusicOnHold application is deprecated and will be removed. Use MusicOnHold with duration parameter instead\n");<br>
<br></div><div>From SetMusicOnHold:<br><br> ast_log(LOG_WARNING, "SetMusicOnHold application is deprecated and will be removed. Use Set(CHANNEL(musicclass)=...) instead\n");<br></div></div></div></div></blockquote>
</div>Ok, that seems like a good solution.<div class=""><br><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>><br>
> in chan_sip:<br>
> - "username" (=defaultuser)<br>
</div>Username actually has multiple functions, which is why I separated one of them<br>
to defaultuser. username should remain the authentication username or be replaced<br>
by authuser=<br></blockquote><div><br></div><div>Currently, these are aliased together:<br><br> } else if (!strcasecmp(v->name, "username") || !strcmp(v->name, "defaultuser")) { /* "username" is deprecated */<br>
ast_string_field_set(peer, username, v->value);<br> if (!strcasecmp(v->name, "username")) {<br> if (deprecation_warning) {<br> ast_log(LOG_NOTICE, "The 'username' field for sip peers has been deprecated in favor of the term 'defaultuser'\n");<br>
deprecation_warning = 0;<br> }<br> <br></div><div>The peer username field would not be removed or altered; I'd propose that the alias would merely be removed in favour of "defaultuser". This has been deprecated (and a NOTICE emitted) since 1.6.0.<br>
</div></div></div></div></blockquote></div>I did not add that deprecation and propably missed it being done. I think it's wrong until we have a solution</div><div>for auth user. We can separate them - but that means some code change.</div>
<div>I vote NO for removing this until we have solved the issues.</div><br></div></blockquote><div><br></div><div>I'm not sure how strongly Walter feels about removing this option, but I could go either way. I definitely understand the desire to have a more permanent solution than simply moving the name (with many purposes) from 'username' to 'defaultuser', and I'm okay with keeping this option until a more complete solution is provided.<br>
<br></div><div>Walter - any thoughts?<br><br>Matt<br></div><div> </div></div>-- <br><div dir="ltr"><div>Matthew Jordan<br></div><div>Digium, Inc. | Engineering Manager</div><div>445 Jan Davis Drive NW - Huntsville, AL 35806 - USA</div>
<div>Check us out at: <a href="http://digium.com" target="_blank">http://digium.com</a> & <a href="http://asterisk.org" target="_blank">http://asterisk.org</a></div></div>
</div></div>