<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3419/">https://reviewboard.asterisk.org/r/3419/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Benjamin Keith Ford.</div>
<p style="color: grey;"><i>Updated June 26, 2014, 12:21 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Committed in revision 5182</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-23562">ASTERISK-23562</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This test verifies that when two PJSIP endpoints are in a call with video enabled, fast picture updates can be received when one endpoint requests INFO. The following code was added as well to create a TestEvent that spawns when the INFO is created:
Index: channels/chan_pjsip.c
===================================================================
--- channels/chan_pjsip.c (revision 408267)
+++ channels/chan_pjsip.c (working copy)
@@ -57,6 +57,7 @@
#include "asterisk/stasis_endpoints.h"
#include "asterisk/stasis_channels.h"
#include "asterisk/indications.h"
+#include "asterisk/manager.h"
#include "asterisk/res_pjsip.h"
#include "asterisk/res_pjsip_session.h"
@@ -1112,8 +1113,14 @@
ao2_cleanup(channel->session);
}
}
+ manager_event(EVENT_FLAG_TEST, "TestEvent",
+ "Type: AST_CONTROL_VIDUPDATE\r\n"
+ "Result: Success");
} else {
res = -1;
+ manager_event(EVENT_FLAG_TEST, "TestEvent",
+ "Type: AST_CONTROL_VIDUPDATE\r\n"
+ "Result: Failure");
}
break;
case AST_CONTROL_CONNECTED_LINE:</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>./asterisk/trunk/tests/channels/pjsip/video_calls/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/video_calls/fast_picture_update/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/video_calls/fast_picture_update/sipp/start-call.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/video_calls/fast_picture_update/sipp/receive-call.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/video_calls/fast_picture_update/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/video_calls/fast_picture_update/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/tests.yaml <span style="color: grey">(4918)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3419/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>