<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3674/">https://reviewboard.asterisk.org/r/3674/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 26th, 2014, 6:54 a.m. EDT, <b>Joshua Colp</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/3674/diff/1/?file=60929#file60929line5309" style="color: black; font-weight: bold; text-decoration: underline;">/team/group/media_formats-reviewed-trunk/main/channel.c</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static int set_format(struct ast_channel *chan,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">5309</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span>rawformat = ast_format_copy(best_native_fmt);</pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">5309</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span>/* BUGBUG: writing to parameter variables rawformat / format? */</pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't understand the BUGBUG</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It seemed weird to me that the parameters are being used like normal variables, but now I see that the input variable was used above here. I'll remove this comment.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 26th, 2014, 6:54 a.m. EDT, <b>Joshua Colp</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/3674/diff/1/?file=60936#file60936line1361" style="color: black; font-weight: bold; text-decoration: underline;">/team/group/media_formats-reviewed-trunk/main/translate.c</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int ast_translator_best_choice(struct ast_format_cap *dst_cap,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1361</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="o">*</span><span class="n">dst_fmt_out</span> <span class="o">=</span> <span class="n">ast_format_copy</span><span class="p">(</span><span class="n">best</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1357</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="cm">/* BUGBUG:</span></pre></td>
</tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1362</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="o">*</span><span class="n">src_fmt_out</span> <span class="o">=</span> <span class="n">ast_format_copy</span><span class="p">(</span><span class="n">bestdst</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1358</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"><span class="tb"> </span> * What if *dst_fmt_out / *src_fmt_out are already holding refs</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1359</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"><span class="tb"> </span> * We need to audit callers, I beleive I've seen leaks from<span class="ew"> </span></span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1360</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"><span class="tb"> </span> * ast_translator_best_choice but ao2_replace causes undefined variable</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1361</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"><span class="tb"> </span> * access (reported by valgrind).</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1362</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"><span class="tb"> </span> */</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Agreed. Interesting re: valgrind...
What if the variables passed in weren't initialized at the start to NULL?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I believe some cases we have:
struct ast_format *dst_fmt;
struct ast_format *src_fmt;
ast_translator_best_choice(dst_cap, src_cap, &dst_fmt, &src_fmt);
Where ao2_replace on *dst_fmt_out would cause undefined memory access. I suspect that in other cases dst_fmt or src_fmt is initialized and holding a reference (thus the leak). I can't say for sure but I've traced some leaking that I think has to do with this procedure, and this ao2_bump seems to me like the most likely suspect.</pre>
<br />
<p>- Corey</p>
<br />
<p>On June 25th, 2014, 5:38 p.m. EDT, Corey Farrell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, Joshua Colp and Matt Jordan.</div>
<div>By Corey Farrell.</div>
<p style="color: grey;"><i>Updated June 25, 2014, 5:38 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove ast_format_copy, make use of ao2_bump directly. Use ao2_replace where appropriate.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compile only.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/team/group/media_formats-reviewed-trunk/tests/test_core_format.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/res/res_speech.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/res/res_rtp_asterisk.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/res/res_musiconhold.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/res/res_fax.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/res/res_agi.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/res/res_adsi.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/main/translate.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/main/smoother.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/main/slinfactory.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/main/rtp_engine.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/main/indications.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/main/frame.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/main/file.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/main/channel.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/main/bridge_channel.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/main/audiohook.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/main/app.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/main/abstract_jb.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/include/asterisk/slin.h <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/include/asterisk/format.h <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/codecs/ex_ulaw.h <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/codecs/ex_speex.h <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/codecs/ex_lpc10.h <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/codecs/ex_ilbc.h <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/codecs/ex_gsm.h <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/codecs/ex_g726.h <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/codecs/ex_g722.h <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/codecs/ex_alaw.h <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/codecs/ex_adpcm.h <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/codecs/codec_dahdi.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/channels/chan_phone.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/channels/chan_oss.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/channels/chan_misdn.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/channels/chan_dahdi.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/channels/chan_alsa.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/bridges/bridge_softmix.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/apps/app_waitforsilence.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/apps/app_test.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/apps/app_talkdetect.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/apps/app_speech_utils.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/apps/app_sms.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/apps/app_record.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/apps/app_nbscat.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/apps/app_mp3.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/apps/app_milliwatt.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/apps/app_ices.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/apps/app_festival.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/apps/app_fax.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/apps/app_dictate.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/apps/app_dahdibarge.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/apps/app_chanspy.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/apps/app_amd.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/addons/chan_ooh323.c <span style="color: grey">(417232)</span></li>
<li>/team/group/media_formats-reviewed-trunk/addons/chan_mobile.c <span style="color: grey">(417232)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3674/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>