<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/3625/">https://reviewboard.asterisk.org/r/3625/</a>
     </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By Corey Farrell.</div>


<p style="color: grey;"><i>Updated June 19, 2014, 4:18 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Address Matt's findings.</pre>
  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Updates to allow most of the Asterisk core to compile.  I've excluded main/channel.c, main/dsp.c and main/rtp_engine.c.  Changes to those files will be posted separate since I feel they are more complex and likely to have more error's.  If any of the files included in this review fit that description let me know and I will split them off.

This change does not include any replacement for calls to ast_format_is_slinear(), and adds it back to the header (but does not implement).  So ast_format_is_slinear hasn't been fixed, just deferred to become a link error.

The modifications to chan_phone are to allow what I believe to be a comparability function to be in the correct namespace to be implemented in format_compatibility.c.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/team/group/media_formats-reviewed/main/stasis_channels.c <span style="color: grey">(416235)</span></li>

 <li>/team/group/media_formats-reviewed/main/sounds_index.c <span style="color: grey">(416235)</span></li>

 <li>/team/group/media_formats-reviewed/main/sorcery.c <span style="color: grey">(416235)</span></li>

 <li>/team/group/media_formats-reviewed/main/slinfactory.c <span style="color: grey">(416235)</span></li>

 <li>/team/group/media_formats-reviewed/main/media_index.c <span style="color: grey">(416235)</span></li>

 <li>/team/group/media_formats-reviewed/main/manager.c <span style="color: grey">(416235)</span></li>

 <li>/team/group/media_formats-reviewed/main/indications.c <span style="color: grey">(416235)</span></li>

 <li>/team/group/media_formats-reviewed/main/image.c <span style="color: grey">(416235)</span></li>

 <li>/team/group/media_formats-reviewed/main/frame.c <span style="color: grey">(416235)</span></li>

 <li>/team/group/media_formats-reviewed/main/format_pref.c <span style="color: grey">(416235)</span></li>

 <li>/team/group/media_formats-reviewed/main/format_compatibility.c <span style="color: grey">(416235)</span></li>

 <li>/team/group/media_formats-reviewed/main/format.c <span style="color: grey">(416235)</span></li>

 <li>/team/group/media_formats-reviewed/main/file.c <span style="color: grey">(416235)</span></li>

 <li>/team/group/media_formats-reviewed/main/dial.c <span style="color: grey">(416235)</span></li>

 <li>/team/group/media_formats-reviewed/main/data.c <span style="color: grey">(416235)</span></li>

 <li>/team/group/media_formats-reviewed/main/core_unreal.c <span style="color: grey">(416235)</span></li>

 <li>/team/group/media_formats-reviewed/main/core_local.c <span style="color: grey">(416235)</span></li>

 <li>/team/group/media_formats-reviewed/main/codec.c <span style="color: grey">(416235)</span></li>

 <li>/team/group/media_formats-reviewed/include/asterisk/slinfactory.h <span style="color: grey">(416235)</span></li>

 <li>/team/group/media_formats-reviewed/include/asterisk/rtp_engine.h <span style="color: grey">(416235)</span></li>

 <li>/team/group/media_formats-reviewed/include/asterisk/format_pref.h <span style="color: grey">(416235)</span></li>

 <li>/team/group/media_formats-reviewed/include/asterisk/format_compatibility.h <span style="color: grey">(416235)</span></li>

 <li>/team/group/media_formats-reviewed/include/asterisk/format_cache.h <span style="color: grey">(416235)</span></li>

 <li>/team/group/media_formats-reviewed/include/asterisk/format.h <span style="color: grey">(416235)</span></li>

 <li>/team/group/media_formats-reviewed/include/asterisk/file.h <span style="color: grey">(416235)</span></li>

 <li>/team/group/media_formats-reviewed/channels/chan_phone.c <span style="color: grey">(416235)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/3625/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>