<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1152/">https://reviewboard.asterisk.org/r/1152/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 17th, 2014, 10:37 a.m. CDT, <b>Jonathan Rose</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You have a lot of instances of trailing whitespace and some of mixed tabs and spaces in here that need to be cleaned up per Asterisk coding guidelines (https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines)</pre>
</blockquote>
<p>On June 17th, 2014, 10:49 a.m. CDT, <b>Jonathan Rose</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">On reflection, my reviewboard post ordering was out of whack and this is probably so old that no one is going to update it. This review should probably be closed.</pre>
</blockquote>
<p>On June 17th, 2014, 11:26 a.m. CDT, <b>astmiv</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am still following and awaiting comments. Even when it is more than three years since I posted my patch.
Thank you for the feedback. I will clean up the code next week but is someone going to approve it?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We've generally been fairly decent about reviewing stuff towards the top of the pile lately, so I think it'll get more feedback at the very least. I'll be sure to follow up.</pre>
<br />
<p>- Jonathan</p>
<br />
<p>On May 22nd, 2011, 1:59 a.m. CDT, astmiv wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and pitlicek@gmail.com.</div>
<div>By astmiv.</div>
<p style="color: grey;"><i>Updated May 22, 2011, 1:59 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch will add access to any calendar folder within Exchange 2007 and 2010.
The current resource only gives access to the default calendar folder of the specified user. With this patch it is possible to access any calendar folder within the system as long as the user has read rights to the folder and its complete folder path.
For example:
- Calendar folders below the publicfoldersroot.
- Calendar folders below the user's mailbox outside of his default calendar.
- Calendar folders below the user's default calendar.
- etc....
Also did some cleanup for XML schema labeling. They are now all the same.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested the following scenario's:
- Access to default calendar of specified user. (folderbase not specified or folderbase=calendar)
- Access to shared default calendar of other person. (mailbox=emailother@company.com and folderbase not specified or folderbase=calendar)
- Access to calendar folder, named testfolder1, below default Calendar. (folderbase=calendar and folderpath=/testfolder1)
- Access to calendar folder, named testfolder2, below a subfolder, named testfolder3, of the default Calendar. (folderbase=calendar and folderpath=/testfolder3/testfolder2)
- Access to calendar folder in Public Folders. (folderbase=publicfoldersroot and folderpath=/meetingroom1)
- Access to calendar folder below a subfolder in Public Folders. (folderbase=publicfoldersroot and folderpath=/meetingrooms/meetingroom1)
- Access to calendar folder below mailbox of specified user. (folderbase=msgfolderroot and folderpath=/calendar2)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/res/res_calendar_ews.c <span style="color: grey">(311843)</span></li>
<li>/trunk/configs/calendar.conf.sample <span style="color: grey">(311843)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1152/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>