<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3363/">https://reviewboard.asterisk.org/r/3363/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Mark Michelson.</div>
<p style="color: grey;"><i>Updated June 15, 2014, 7:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">With the exception of Scott's suggestion about checking for the type of data in the table, I have addressed all feedback here.
The biggest change to note here is that all lookups in the table are now performed using regex. This, combined with the extra LIKE handling that opticron pointed out, makes lookups more reliable, though almost certainly slower. I'm not too concerned with performance in a testsuite module though.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This introduces a new pluggable module to the Asterisk testsuite intended to assist in testing using realtime storage. The test module sets up an HTTP server on port 8000 and services requests Asterisk makes using its res_config_curl realtime backend. The actual data is stored in memory in python using simple dictionaries and lists. The test module configuration allows for data to be preloaded into python before Asterisk is started so that Asterisk may retrieve realtime data during startup. Once AMI is connected to Asterisk, the realtime test module hands over control to a python module so that the test may be further controlled by the test writer.
Along with the module are six realtime tests, each designed to test an operation that Asterisk can attempt. The "require" operation is not tested since we currently always claim to have the proper items stored in the expected way.
There are potential improvements that could be made, such as:
* Memoization of HTTP resources served by the test module.
* yaml-driven test development beyond the initial population of realtime data.
* Potentially allow for the realtime test module to be run stand-alone so that developers can have an easy realtime store to use for testing.
None of these are enough to prevent inclusion into the test suite though.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/tests.yaml <span style="color: grey">(5118)</span></li>
<li>/asterisk/trunk/tests/realtime/update/update.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/update/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/update/configs/ast1/sorcery.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/update/configs/ast1/extconfig.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/store/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/store/store.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/store/configs/ast1/sorcery.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/store/configs/ast1/extconfig.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/static/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/static/static.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/static/configs/ast1/modules.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/static/configs/ast1/extconfig.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/single/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/single/single.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/single/configs/ast1/sorcery.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/single/configs/ast1/extconfig.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/multi/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/multi/multi.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/multi/configs/ast1/sorcery.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/multi/configs/ast1/extconfig.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/destroy/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/destroy/destroy.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/destroy/configs/ast1/sorcery.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/destroy/configs/ast1/extconfig.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/realtime_test_module.py <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3363/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>