<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3560/">https://reviewboard.asterisk.org/r/3560/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/3560/diff/3/?file=59480#file59480line679" style="color: black; font-weight: bold; text-decoration: underline;">asterisk/trunk/lib/python/asterisk/sipp.py</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">679</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="bp">self</span><span class="o">.</span><span class="n">_our_exit_deferred</span> <span class="o">=</span> <span class="n">defer</span><span class="o">.</span><span class="n">Deferred</span><span class="p">()</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You may want to run this through pylint.
Declaring class member attributes outside of a constructor is a warning under PEP8. You should declare these in the constructor and set them to None.
Alternatively, many of these deferreds do not have to be member attributes. You can pass them as arguments to addCallback, which will pass them to the function being called when the deferred is triggered.</pre>
</div>
<br />
<p>- Matt Jordan</p>
<br />
<p>On June 10th, 2014, 8:01 a.m. CDT, opticron wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By opticron.</div>
<p style="color: grey;"><i>Updated June 10, 2014, 8:01 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-23643">ASTERISK-23643</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This adds tests for nominal callee- and caller-initiated attended transfer scenarios using SIPp scenarios and SIPp's 3PCC to coordinate call state. This also adds another sample SIPp scenario for handling the REFER initiator behavior as a UAS that works with referee.xml (the UAC attended transfer coordinator).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ensured that the tests performed as expected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>asterisk/trunk/tests/channels/pjsip/transfers/tests.yaml <span style="color: grey">(5100)</span></li>
<li>asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local/sipp/uas.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local/sipp/referer.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local/sipp/referee.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local/attended_transfer.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local/sipp/uas.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local/sipp/uac-no-hangup.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local/sipp/referer_uas.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local/sipp/referee.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local/attended_transfer.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/lib/python/asterisk/sipp.py <span style="color: grey">(5100)</span></li>
<li>asterisk/trunk/contrib/sipp/transfer/referer_uas.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/contrib/sipp/table_of_contents <span style="color: grey">(5100)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3560/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>