<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3598/">https://reviewboard.asterisk.org/r/3598/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This currently has an issue due to module load order which I'm working on resolving. It should barely impact the code.</pre>
<br />
<p>- Joshua Colp</p>
<br />
<p>On June 10th, 2014, 1:21 p.m. UTC, Joshua Colp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Joshua Colp.</div>
<p style="color: grey;"><i>Updated June 10, 2014, 1:21 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This change adds persistence support to res_pjsip_pubsub.
What does this mean?
As subscriptions are created and destroyed their state is kept in sorcery. By default this uses the local astdb but realtime support is also possible. If Asterisk goes down and is restarted these subscriptions are retrieved and recreated as if nothing had happened.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Did "core stop now" and "core restart now" multiple times. Confirmed, via wireshark, that the expected NOTIFY was sent out upon startup as if nothing had happened. Tested using the default persistence of going to astdb and also configured it to persist through realtime -> ODBC -> MySQL.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/12/res/res_pjsip_pubsub.exports.in <span style="color: grey">(415169)</span></li>
<li>/branches/12/res/res_pjsip_pubsub.c <span style="color: grey">(415169)</span></li>
<li>/branches/12/res/res_pjsip_mwi.c <span style="color: grey">(415169)</span></li>
<li>/branches/12/res/res_pjsip_exten_state.c <span style="color: grey">(415169)</span></li>
<li>/branches/12/res/res_pjsip.c <span style="color: grey">(415169)</span></li>
<li>/branches/12/include/asterisk/res_pjsip_pubsub.h <span style="color: grey">(415169)</span></li>
<li>/branches/12/include/asterisk/res_pjsip.h <span style="color: grey">(415169)</span></li>
<li>/branches/12/contrib/ast-db-manage/config/versions/c6d929b23a8_create_pjsip_subscription_persistence_.py <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3598/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>