<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3547/">https://reviewboard.asterisk.org/r/3547/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Matt Jordan.</div>
<p style="color: grey;"><i>Updated May 28, 2014, 5:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Committed in revision 414798</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch addresses some aesthetic issues in Asterisk. These are all just minor tweaks to improve the look of the CLI when used in a variety of settings. Specifically:
* A number of chatty verbose messages were removed or demoted to DEBUG messages. Verbose messages with a verbosity level of 5 or higher were - if kept as verbose messages - demoted to level 4. Several messages that were emitted at verbose level 3 were demoted to 4, as announcement of dialplan applications being executed occur at level 3 (and so the effects of those applications should generally be less).
* Some verbose messages that only appear when their respective 'debug' options are enabled were bumped up to always be displayed.
* Prefix/timestamping of verbose messages were moved to the verboser handlers. This was done to prevent duplication of prefixes when the timestamp option (-T) is used with the CLI.
* Verbose magic is removed from messages before being emitted to non-verboser handlers. This prevents the magic in multi-line verbose messages (such as SIP debug traces or the output of DumpChan) from being written to files.
* _Slightly_ better support for the "light background" option (-W) was added. This includes using ast_term_quit in the output of XML documentation help, as well as changing the "Asterisk Ready" prompt to bright green on the default background (which stands a better chance of being displayed properly than bright white).
Overall, the output of starting Asterisk with the timestamp option is usable, the colours are a bit more consistent, and the messages displayed when starting Asterisk - with or without verbosity - is cleaner.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/res/res_odbc.c <span style="color: grey">(414121)</span></li>
<li>/trunk/res/res_jabber.c <span style="color: grey">(414121)</span></li>
<li>/trunk/res/res_fax.c <span style="color: grey">(414121)</span></li>
<li>/trunk/res/res_config_pgsql.c <span style="color: grey">(414121)</span></li>
<li>/trunk/res/res_config_odbc.c <span style="color: grey">(414121)</span></li>
<li>/trunk/res/res_config_curl.c <span style="color: grey">(414121)</span></li>
<li>/trunk/res/parking/parking_applications.c <span style="color: grey">(414121)</span></li>
<li>/trunk/main/xmldoc.c <span style="color: grey">(414121)</span></li>
<li>/trunk/main/pbx.c <span style="color: grey">(414121)</span></li>
<li>/trunk/main/optional_api.c <span style="color: grey">(414121)</span></li>
<li>/trunk/main/logger.c <span style="color: grey">(414121)</span></li>
<li>/trunk/main/loader.c <span style="color: grey">(414121)</span></li>
<li>/trunk/main/config_options.c <span style="color: grey">(414121)</span></li>
<li>/trunk/main/bridge.c <span style="color: grey">(414121)</span></li>
<li>/trunk/main/asterisk.c <span style="color: grey">(414121)</span></li>
<li>/trunk/include/asterisk/logger.h <span style="color: grey">(414121)</span></li>
<li>/trunk/channels/chan_unistim.c <span style="color: grey">(414121)</span></li>
<li>/trunk/cel/cel_pgsql.c <span style="color: grey">(414121)</span></li>
<li>/trunk/cel/cel_odbc.c <span style="color: grey">(414121)</span></li>
<li>/trunk/cdr/cdr_sqlite3_custom.c <span style="color: grey">(414121)</span></li>
<li>/trunk/cdr/cdr_pgsql.c <span style="color: grey">(414121)</span></li>
<li>/trunk/cdr/cdr_odbc.c <span style="color: grey">(414121)</span></li>
<li>/trunk/cdr/cdr_adaptive_odbc.c <span style="color: grey">(414121)</span></li>
<li>/trunk/bridges/bridge_builtin_features.c <span style="color: grey">(414121)</span></li>
<li>/trunk/apps/app_waitforsilence.c <span style="color: grey">(414121)</span></li>
<li>/trunk/apps/app_voicemail.c <span style="color: grey">(414121)</span></li>
<li>/trunk/apps/app_mixmonitor.c <span style="color: grey">(414121)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3547/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>