<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 05/23/2014 08:17 PM, Matthew Jordan
wrote:<br>
</div>
<blockquote
cite="mid:CAN2PU+468qsecwtFMtWmgVnkOj3A4M1nCZJJZGbGZRm2qR3xBg@mail.gmail.com"
type="cite">
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Sun, May 18, 2014 at 1:57 AM,
Petros Moisiadis <span dir="ltr"><<a
moz-do-not-send="true" href="mailto:ernest0x@yahoo.gr"
target="_blank">ernest0x@yahoo.gr</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<div>
<div class="h5">
<div>On 05/16/2014 04:50 PM, Olle E Johansson wrote:<br>
</div>
<blockquote type="cite">
<div
style="font-family:Verdana,Arial,Helvetica,Sans-Serif">
<table style="border:1px #c9c399 solid"
bgcolor="#f9f3c9" cellpadding="8" width="100%">
<tbody>
<tr>
<td> This is an automatically generated
e-mail. To reply, visit: <a
moz-do-not-send="true"
href="https://reviewboard.asterisk.org/r/3546/"
target="_blank">https://reviewboard.asterisk.org/r/3546/</a>
</td>
</tr>
</tbody>
</table>
<br>
<table
style="background-image:url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png');background-repeat:repeat-x;border:1px
black solid" bgcolor="#fefadf" cellpadding="8"
cellspacing="0" width="100%">
<tbody>
<tr>
<td>
<div>Review request for Asterisk
Developers.</div>
<div>By Olle E Johansson.</div>
<div style="margin-top:1.5em"> <b
style="color:#575012;font-size:10pt">Repository:
</b> Asterisk </div>
<h1
style="color:#575012;font-size:10pt;margin-top:1.5em">Description
</h1>
<table style="border:1px solid #b8b5a0"
bgcolor="#ffffff" cellpadding="10"
cellspacing="0" width="100%">
<tbody>
<tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">This code in channel.c is wrong. It first checks if we have a length. If not, we set it to a measured time, which is fine.
If we have a length and it's under the minimum DTMF duration, we set it again to the measured time. In an RTP session, the duration can be under minimum, but has no relationship to the measured time between DTMF start and end. We should keep the given RTP DTMF time and use that for emulation. I have had DTMF that was extended by up to 60 ms because of this code and that really, really broke communication for these alarm panels that send many short DTMF tones.
I suggest that this fix goes into 1.8 and later revisions.</pre>
</td>
</tr>
</tbody>
</table>
<h1
style="color:#575012;font-size:10pt;margin-top:1.5em">Testing
</h1>
<table style="border:1px solid #b8b5a0"
bgcolor="#ffffff" cellpadding="10"
cellspacing="0" width="100%">
<tbody>
<tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Hours and hours of reading DTMF logs. Countless cups of tea. A gazillion milliseconds wasted. All tested in 1.8.</pre>
</td>
</tr>
</tbody>
</table>
<h1
style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs
</h1>
<ul
style="margin-left:3em;padding-left:0">
<li>/trunk/main/channel.c <span
style="color:grey">(414046)</span></li>
</ul>
<p><a moz-do-not-send="true"
href="https://reviewboard.asterisk.org/r/3546/diff/"
style="margin-left:3em"
target="_blank">View Diff</a></p>
</td>
</tr>
</tbody>
</table>
</div>
<br>
<fieldset></fieldset>
<br>
</blockquote>
<br>
</div>
</div>
Hello,<br>
<br>
Could this patch help with high cpu usage issue #21872?<br>
</div>
<br clear="all">
</blockquote>
</div>
<br>
</div>
<div class="gmail_extra">Highly unlikely. The root cause of that
performance problem has not really been found, as it has not
been reproduced on a consistent basis by any bug marshal. This
patch - at least so far - is not looking to address any
performance problems so much as DTMF emulation extending
digits when it shouldn't.<br>
</div>
<div class="gmail_extra"><br>
-- <br>
<div dir="ltr">
<div>Matthew Jordan<br>
</div>
<div>Digium, Inc. | Engineering Manager</div>
<div>445 Jan Davis Drive NW - Huntsville, AL 35806 - USA</div>
<div>Check us out at: <a moz-do-not-send="true"
href="http://digium.com" target="_blank">http://digium.com</a>
& <a moz-do-not-send="true"
href="http://asterisk.org" target="_blank">http://asterisk.org</a></div>
</div>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
<br>
Sorry for being off-topic then, but the performance bug can be
consistently reproduced following the steps described at this
comment:<br>
<br>
<a class="moz-txt-link-freetext" href="https://issues.asterisk.org/jira/browse/ASTERISK-21872?focusedCommentId=211533&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-211533">https://issues.asterisk.org/jira/browse/ASTERISK-21872?focusedCommentId=211533&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-211533</a><br>
<br>
So, if any developer has already tried these steps but did not
manage to reproduce this, it would be really helpful if he could
share his experience with a post on that issue. Perhaps it is also
possible to be given access to an environment on which this can be
reproduced.<br>
</body>
</html>