<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3525/">https://reviewboard.asterisk.org/r/3525/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Joshua Colp.</div>
<div>By opticron.</div>
<p style="color: grey;"><i>Updated May 19, 2014, 1:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Intermediate rework update. All issues brought up by Matt have been addressed except the rework on the reusable code.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-23641">ASTERISK-23641</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This reworks a significant portion of the ARI attended transfer test to avoid dependence on pjsua since it has the tendency to cause sporadic (and sometimes consistent) test failures. The reworked test uses SIPp with 3PCC to manage the transfer scenario.
This change also gives WebSocketEventModule (and anything else using EventMatcher) the ability to spawn SIPp scenarios in response to websocket events.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ensured that the test was operating as expected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>asterisk/trunk/tests/rest_api/bridges/attended_transfer/test-config.yaml <span style="color: grey">(5043)</span></li>
<li>asterisk/trunk/tests/rest_api/bridges/attended_transfer/sipp/referer.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/rest_api/bridges/attended_transfer/sipp/referee.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/rest_api/bridges/attended_transfer/attended_transfer.py <span style="color: grey">(5043)</span></li>
<li>asterisk/trunk/lib/python/asterisk/ari.py <span style="color: grey">(5043)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3525/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>